Open ibotty opened 9 years ago
aww. all the comments were blown away after rebase'ing.
Ahhh.. that's what rebasing does. Did you copy the old ones over are some still missing?
I'm happy to review this! Perhaps not until fairly late today or tomorrow, though.
I re-added the comments manually.
BTW: It's also possible to use urandom directly (without using any state). I can only think about an interface using cryptonite's MonadRandom
which is not as mechanical a refactoring and would most likely change API.
All in all unless there are specific concerns you'd like to discuss, please feel free to merge it!
And thanks for putting it together! It's very good to track Vincent's work.
This one you can also merge :)
Port to cryptonite, uses
ChaCha
instead ofurandom
as before.Some changes are non-trivial and I'd be glad if you, @tel, could kindly review them.