tel / oauthenticated

Authentication-ho! OAuth 1.0 for Haskell atop http-conduit.
MIT License
6 stars 6 forks source link

Cryptonite #16

Open ibotty opened 9 years ago

ibotty commented 9 years ago

Port to cryptonite, uses ChaCha instead of urandom as before.

Some changes are non-trivial and I'd be glad if you, @tel, could kindly review them.

ibotty commented 9 years ago

aww. all the comments were blown away after rebase'ing.

tel commented 9 years ago

Ahhh.. that's what rebasing does. Did you copy the old ones over are some still missing?

I'm happy to review this! Perhaps not until fairly late today or tomorrow, though.

ibotty commented 9 years ago

I re-added the comments manually.

ibotty commented 9 years ago

BTW: It's also possible to use urandom directly (without using any state). I can only think about an interface using cryptonite's MonadRandom which is not as mechanical a refactoring and would most likely change API.

tel commented 9 years ago

All in all unless there are specific concerns you'd like to discuss, please feel free to merge it!

tel commented 9 years ago

And thanks for putting it together! It's very good to track Vincent's work.

tel commented 8 years ago

This one you can also merge :)