search

tel / oauthenticated

Authentication-ho! OAuth 1.0 for Haskell atop http-conduit.
MIT License
6 stars 6 forks source link

RFC: use MonadRandom #17

Open ibotty opened 9 years ago

ibotty commented 9 years ago

See commit b39e1e0 for the meat. It makes a few things way easier. The user will need to supply the MonadRandom instance to use though (or stay within IO to use urandom as before the cryptonite port).

ibotty commented 9 years ago

Ignore the comments that belong to the cryptonite port.

I like the API with MonadRandom, having ported a client using oauthenticated to use MonadRandom.

If you are ok with it (and kindly looked over the changes in crypto), I'd prefer to go ahead with this approach.

tel commented 9 years ago

I think most likely that the policy of tracking Vincent's design is best. I will take a closer look at the MonadRandom module though, first.

tel commented 9 years ago

I also like the elimination of oauthSimple, that's a nice consequence!

tel commented 9 years ago

Ok! I'm a big fan of this design. Lets go this way!

I also really like your style naming the monad variable io as it'll be a nice hint to new users.

ibotty commented 8 years ago

Are you fine with merging that pull request and releasing it on hackage. I am using that pull request in production for a few month now.

tel commented 8 years ago

Yeah, go ahead and merge it!