search

tel / saltine

Cryptography that's easy to digest (NaCl/libsodium bindings)
https://github.com/tel/saltine
MIT License
61 stars 29 forks source link

Add AEAD, add sb_detached, unit->property tests, more tests, color output #38

Closed TomMD closed 6 years ago

TomMD commented 6 years ago

The title summarizes it. This is a monolithic PR and I can break it up if desired. The changes are basically three fold:

  1. Add an AEAD module using Saltine's XChaChaPoly1305 AEAD.
  2. Add secrebox_detached.
  3. Improve the test framework.
linearray commented 6 years ago

Tom,

this is great, thanks a lot for your contributions.

I just think before exposing the badly named randomVector we should rename it to something more accurate. Vector is a historical remnant, AFAICT everything was switched to ByteString long ago and the word vector only remains in various function names. randomByteString? randomBS?

Suggestions welcome.

linearray commented 6 years ago

Sorry for introducing conflicts in the meanwhile. If you can resolve them I can merge this and we think about naming before releasing 0.1.0.0

TomMD commented 6 years ago

Heh, good idea. I've renamed it to randomByteString which seems like a sensible long-term name. I've also re-merged master, handled the conflict, and re-tested.