Closed NicolasT closed 1 year ago
I'm very unsure how some test can, given this change, only fail on a specific GHC version :thinking:
Yeah, we had some intermittently failing tests before, I have now started to collect info in issue #63, because it is concerning.
Thanks for the PR!
Two patches (could be cherry-picked if desired):
Show
instances for various datatypes.Before:
After:
(Notice the placement of the final
}
).Show
instances forBox.Keypair
andSign.Keypair
: their respectivesecretKey
andpublicKey
fields have validShow
instances, so I assume it's fine to addShow
instances for the pairs as well.I tried to use the same approach/formatting of string form as is used for
Box.PrivateKey
etc. instead of using automatically-derived instances (which would be simpler, or course). As a result, they're not compatible with a (hypothetical) auto-derivedRead
instance or can't be copy-pasted as-is in code/a REPL.