tel8618217223380 / cpassman

Automatically exported from code.google.com/p/cpassman
0 stars 0 forks source link

IE Error on Items page : Stop running this script? #268

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Go to Password list (items page)
2. Click on a folder with many items listed 10+
3. Error will popup

What is the expected output? What do you see instead?
View item details.

What version of the product are you using?
2.1.6

On what operating system? With what Browser (IEx, FFx, ...)
IE8 and FF8

Please provide any additional information below.

This works perfect in FF its in IE where it pops up the following after 
clicking on a folder that has a long list of items. 

"Stop running this script?
A script on this page is causing Internet Explorer to run slowly. If it 
continues to run, your computer might become unresponsive."

Again this only happens in IE and only on folders that have a long list of 
items. A little googling suggests that this is due to looping and perhaps 
elements need to be separated.

Original issue reported on code.google.com by hexxamil...@gmail.com on 11 Apr 2012 at 9:07

GoogleCodeExporter commented 9 years ago
I would like to know if there are any thoughts on this. I have had to revert 
back to 1.82 because of this error in IE. The "Stop running this script?" error 
does not exist in 1.82.

Original comment by hexxamil...@gmail.com on 16 Apr 2012 at 6:28

GoogleCodeExporter commented 9 years ago
IE8 is an old browser that gives me some white hair.
It's difficult to manage those kind of old browser.

I'll try to correct that but please try to use a more newer browser, at least 
IE9 which has a better compliance with javascript stuff.

Original comment by nils.cpa...@gmail.com on 17 Apr 2012 at 7:59

GoogleCodeExporter commented 9 years ago
Trust me. I wish IE did not exist but unfortunately IE8 is still a standard for 
my user base so I have to cater to that. I don't have this issue with Firefox 
of course and this issue only seems to occur in IE when there is a long list of 
items. Could it be the method of how the items are being queried?

Original comment by hexxamil...@gmail.com on 18 Apr 2012 at 6:12

GoogleCodeExporter commented 9 years ago
I fixed this by modifying the items.load.php class. Apparently using AJAX in IE 
timesout trying to load all of the items at once. So I have edited it to load 7 
at a time and there is no longer an error. Again, this is no problem in Firefox 
only IE.

Why 7? Well loading more than 7 items causes the error pop up again asking 
"Stop running this script? A script on this page is causing Internet Explorer 
to run slowly. If it continues to run, your computer might become unresponsive."

I modified the items.load.php class as follows.

From this:
/adapt to the screen height
$("#nb_items_to_display_once").val(Math.round((window_height-450)/23));

To this:
/adapt to the screen height
//$("#nb_items_to_display_once").val(Math.round((window_height-450)/23));
    $("#nb_items_to_display_once").val('7');

Original comment by hexxamil...@gmail.com on 24 Apr 2012 at 10:55

GoogleCodeExporter commented 9 years ago
You can directly go in the Settings page and decide to only show 7 items.

There is a specific option for that ;-)

Nevertheless there is something with the window height calculation that IE8.

Original comment by nils.cpa...@gmail.com on 28 Apr 2012 at 6:18