Tasks value is editable, shouldn't popup task list

[GoogleCodeExporter]

The max task value for a task from a client is a value that determines the 
maximum concurrent tasks the client can run.  The integer value should be 
editable, clicking it should allow modification of the integer value.  If you 
want to popup the defined task list for the client then that should be a 
different button.

Original issue reported on code.google.com by de...@battams.ca on 27 Oct 2010 at 3:03

[GoogleCodeExporter]

I'm not sure what menu and item you are referring to.

Original comment by tom.mira...@gmail.com on 28 Oct 2010 at 12:49

• Changed state: Reviewed

[GoogleCodeExporter]

Shown in screen 16 (attached).  There is an option in a Task called 
getMaxInstances() that allows the setting of the maximum number of instances of 
the task that can be run simultaneously on the client.  That's what that should 
be allowing the user to set.  You can keep the task viewer as well, but you're 
missing the setting of getMaxInstances().

For the task viewer, you ask "what can we do" with a viewed task?  Well, we can 
allow editing of the task directly in the STV if you want to support all of 
that.  Let me know if you want to go that far because it will determine just 
how much work I have to do for issue 168

Original comment by de...@battams.ca on 28 Oct 2010 at 1:32

Attachments:

• sjq4_16.jpg

[GoogleCodeExporter]

Yes, I misunderstood the setting.

See issue 168 for my comments on editing task info.

Original comment by tom.mira...@gmail.com on 28 Oct 2010 at 12:03

• Changed state: Accepted

[GoogleCodeExporter]

We still have a misunderstanding here.  This item uses the 
com.google.code.sagetvaddons.sjq.shared.Client.getTasks() method to determine 
which tasks this Client can handle.  Clicking on the button displays the tasks. 
 (I agree it's not a good idea to allow the user to edit the tasks from here 
since the menu deals with Clients and not tasks.)

Original comment by tom.mira...@gmail.com on 30 Oct 2010 at 10:46

• Changed state: Reviewed

[GoogleCodeExporter]

I confused myself, ignore me. :)  Your implementation is correct.  Marking this 
issue as invalid.

Original comment by de...@battams.ca on 30 Oct 2010 at 12:47

• Changed state: Invalid