tel8618217223380 / sagetv-addons

Automatically exported from code.google.com/p/sagetv-addons
0 stars 0 forks source link

Add ability to view task output to STVi #205

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Next engine build provides the following methods to ServerClient:

public String getTaskLog(long);
public String getTaskLog(long, QueuedTask.OutputType);

These methods allow you to read the logged task output for a given task in the 
queue.  Just present the output in a scroll window for users to see.  The first 
method returns all output (task and test output) in one concatenated string.  
The latter lets you choose which output you get.

Original issue reported on code.google.com by de...@battams.ca on 4 Nov 2010 at 5:05

GoogleCodeExporter commented 9 years ago
Will this work for tasks in any state or only in certain states?

Original comment by tom.mira...@gmail.com on 4 Nov 2010 at 6:48

GoogleCodeExporter commented 9 years ago
It returns the logs for tasks in any state.

Original comment by de...@battams.ca on 4 Nov 2010 at 7:06

GoogleCodeExporter commented 9 years ago
Of course, this would also be a reason to bring back the "show completed tasks" 
option on the main menu.  This would allow users to see the output of tasks 
that have completed/failed and allow them to assess if they need to requeue the 
task.

Original comment by de...@battams.ca on 4 Nov 2010 at 11:20

GoogleCodeExporter commented 9 years ago
I'd like to hold off on adding another main menu item only because of time 
considerations.  I'd like to focus on getting the basic functionality working 
and then add the new main menu item in a follow up release.  

Conceptually it is not difficult because all of the main components will be in 
place.  It would be easier for me if you could create a new method that 
returned all Tasks (in any state, I can filter what I need) in a Map<Client, 
List<Task>>  My vision would be do bring back the "Show All Tasks" menu and 
then let the user filter what Tasks they wanted to see (filter by Client, 
filter by state, filter by Task name, etc.)  This is a bigger job but well 
worth it.

Original comment by tom.mira...@gmail.com on 5 Nov 2010 at 12:24

GoogleCodeExporter commented 9 years ago
Does this mean you only want assigned tasks in the map or do you want null as a 
key, which would refer to all tasks that aren't assigned to a client (i.e. 
tasks in waiting or returned state)?

Not that it should matter, but the map would actually be: Map<Client, 
List<QueuedTask>>

Original comment by de...@battams.ca on 5 Nov 2010 at 1:04

GoogleCodeExporter commented 9 years ago

Original comment by tom.mira...@gmail.com on 5 Nov 2010 at 11:34

GoogleCodeExporter commented 9 years ago
Returning one long string makes for ugly viewing in the STV.  Can you make 
these methods return String[] or List<String>?  If you do that I can setup a 
nicer looking dialog.

Original comment by tom.mira...@gmail.com on 6 Nov 2010 at 5:32

GoogleCodeExporter commented 9 years ago
How are, for example, the plugin release notes or plugin description displayed 
in STV plugin manager?  Can't the same thing be used to display the task logs?  
Do you still need a return value of String[] for the logs?

Original comment by de...@battams.ca on 9 Nov 2010 at 4:48

GoogleCodeExporter commented 9 years ago
I'll look to see how the plugin manager does it. I changed the owner to me for 
now.

What would be an "average" length for the String and what would be a reasonable 
maximum lenght for the String?

Original comment by tom.mira...@gmail.com on 9 Nov 2010 at 8:13

GoogleCodeExporter commented 9 years ago
The plugin manager uses one big String in a scrollable panel so I guess this is 
an OK thing to do.  Closing ticket.

Original comment by tom.mira...@gmail.com on 9 Nov 2010 at 9:49

GoogleCodeExporter commented 9 years ago
Fix verified.

Original comment by de...@battams.ca on 14 Nov 2010 at 2:53