tel8618217223380 / sagetv-addons

Automatically exported from code.google.com/p/sagetv-addons
0 stars 0 forks source link

Need "View Completed Tasks" screen #241

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Same as "Active Tasks" except it shows all the tasks that "Active" doesn't 
(i.e. tasks in 'RETURNED', 'SKIPPED', 'COMPLETED', 'FAILED').  Should auto 
refresh same as active tasks.

Original issue reported on code.google.com by de...@battams.ca on 13 Nov 2010 at 8:15

GoogleCodeExporter commented 9 years ago
Can you confirm and clarify:

DataStore.getActiveQueue() - What's considered "Active"? This is what I use for 
the "Show Queued Tasks" menu so I'm assuming it's everything that not completed.

DataStore.getActiveQueueForClient(Client) - Same as above but only for the 
specified Client.

ServerClient.getActiveQueue() - Exactly the same as DataStore.getActiveQueue()

DataStore.getQueue() - Returns everything in any state. So to get a list of the 
completed Tasks I use this method and filter out Tasks with states that are not 
one of the states in your first comment.

What actions make sense for Completed Tasks? (I think only "remove from list" 
makes sense?)

What method do I use the remove the Completed Task from the list?

Original comment by tom.mira...@gmail.com on 14 Nov 2010 at 1:28

GoogleCodeExporter commented 9 years ago
Active = WAITING, RUNNING, RETURNED

getActiveQueueForClient(Client): Correct, same it just filters for the given 
client

ServerClient.getActiveQueue(): Just calls DataStore.getActiveQueue() underneath 
the hood

DataStore.getQueue(): Returns every task in the queue, regardless of state; to 
get a list of completed you could do set subtraction (i.e. All Tasks - Active 
Tasks = Completed Tasks); I could also create a method for you that does all 
that (open ticket if that's what you want).

Actions: Remove currently isn't an option - it'll be removed automatically 
after being in a completed state for more than 24 hours.  Do you think we 
should add that ability?  If so, open ticket for the API additions.

We could also allow a re-queuing of completed tasks by putting them back to 
'WAITING' state.  I would just have to expose the method to ServerClient (it 
already exists, but it's private to task clients only right now).  I didn't 
think it was a good idea, but I can see benefits to allowing it.  Thoughts?

Original comment by de...@battams.ca on 14 Nov 2010 at 1:54

GoogleCodeExporter commented 9 years ago
I'll filter the Tasks manually, no need for another method.

I remember discussing re queuing Tasks and I think we decided against that, for 
good reasons.  So for now I'll make the menu strictly "view only".

Original comment by tom.mira...@gmail.com on 14 Nov 2010 at 1:18

GoogleCodeExporter commented 9 years ago
I plan on displaying the following for the completed Tasks.  Let me know if 
this makes sense or not:

- Current State
- Assignee (does this make sense for a completed Task?)
- Created
- Started
- Completed
- MetaData (ability to view metadata, does this make sense for a completed 
Task?)
- Queue ID
- Logs (ability to view.)

The menu will look just like the Queued task menu.

Original comment by tom.mira...@gmail.com on 14 Nov 2010 at 1:52

GoogleCodeExporter commented 9 years ago
Yes, I'd show all of those values.  You want to see the assignee in case a task 
fails you may need to investigate the task client that ran it (invalid exe 
settings, etc).  Same with metadata, you may want to view that metadata to 
track down problems with scripts, etc.  So, yes, I'd definitely show every 
field listed above for completed tasks.

Original comment by de...@battams.ca on 14 Nov 2010 at 2:28

GoogleCodeExporter commented 9 years ago
The functionality will be in the next build.  Because of my lack of data I 
can't test this much so just open tickets for any bugs or things that need 
improvement.

Original comment by tom.mira...@gmail.com on 14 Nov 2010 at 5:50

GoogleCodeExporter commented 9 years ago

Original comment by de...@battams.ca on 9 Apr 2013 at 2:12