search

telecapoland / jamendo-android

Official Jamendo Android Player by Teleca Poland
http://telecapoland.blogspot.com/
Apache License 2.0
423 stars 258 forks source link

Quick fix for ICS/JB qualizer bug #32

Open Elettronik opened 11 years ago

Elettronik commented 11 years ago

This fix FC on ICS devices, tested on SGS I900 CM9, the same should work on JB too

MarcinGil commented 11 years ago

Hmm.. I'm not a fan of catching and ignoring exceptions like that. Were you able to find out what is the reason this exception is thrown out?

Elettronik commented 11 years ago

I find some reference on an upstream bug on this classes, which seem it won't fixed.

http://code.google.com/p/cyanogenmod/issues/detail?id=4327 http://code.google.com/p/android/issues/detail?id=33669 http://stackoverflow.com/questions/11193239/using-audiosessionid-value-to-instantiate-audiofx-class

I know it's a bad program style to catch and ignore exception, but seem working on ICS device. maybe a better solution could be logging error, or checking api level you are working on, and then using right classes,