Nevertheless, this PR cannot be merged until you fix the conflicts that would arise if your local branch is directly merged into my upstream develop. This is because there have been changes in the upstream develop that are not within your forked repo. In order to get those changes, you will have to merge the upstream develop into your local branch; this will do the conflicts appear in your local branch, and they are fixed as explained here. Then, both branches will be synchronized except for the new code your are adding.
Great, this definitely LGTM :)
Nevertheless, this PR cannot be merged until you fix the conflicts that would arise if your local branch is directly merged into my upstream develop. This is because there have been changes in the upstream develop that are not within your forked repo. In order to get those changes, you will have to merge the upstream develop into your local branch; this will do the conflicts appear in your local branch, and they are fixed as explained here. Then, both branches will be synchronized except for the new code your are adding.