arcgis sink uniqueId is not updated when customNotification is modified

telefonicaid / fiware-cygnus

A connector in charge of persisting context data sources into other third-party databases and storage systems, creating a historical view of the context

https://fiware-cygnus.rtfd.io/

GNU Affero General Public License v3.0

64 stars 104 forks source link

arcgis sink uniqueId is not updated when customNotification is modified #2349

Closed AlvaroVega closed 7 months ago

AlvaroVega commented 7 months ago

When a custom notification (https://github.com/telefonicaid/fiware-orion/blob/master/doc/manuals/orion-api.md#custom-notifications )like:

{
  "url": "http://host-cygnus/notify",
  "ngsi": {
    "type": "fiwareid"
  },
  "headers": {
    "fiware-service": "base",
    "fiware-servicepath": "/path/FeatureServer/0"
  }
}

is modified to

{
  "url": "http://host-cygnus/notify",
  "ngsi": {
    "type": "name"
  },
  "headers": {
    "fiware-service": "base",
    "fiware-servicepath": "/path/FeatureServer/0"
  }
}

arcgis sink is using new value for type (used by uniqueFiledId)

AlvaroVega commented 7 months ago

https://github.com/telefonicaid/fiware-cygnus/blob/2f2a0a18447b18ced3efb2715ab10b56141ef33b/cygnus-ngsi/src/main/java/com/telefonica/iot/cygnus/sinks/NGSIArcgisFeatureTableSink.java#L389-L393

Maybe we should force to set uniqueId from aggregation always

fgalan commented 7 months ago

PR #2350

danielvillalbamota commented 7 months ago

PR #2350

This solves the issue.