FIX - Replace MongoClientOptions to MongoClientUri in mongoClient of Mongo/STHSinks #2387

kumardeepak5 commented 3 months ago

@AlvaroVega , PR is ready to review.

Edit: issue #2402

AlvaroVega commented 3 months ago

This PR sounds goods to me, but not sure we can introduce this breaking change keeping old options (mongo_hosts, mongo_username, mongo_password, mongo_auth_source, mongo_replica_set) at the first time and removing then in a future.

fgalan commented 3 months ago

This PR sounds goods to me, but not sure we can introduce this breaking change keeping old options (mongo_hosts, mongo_username, mongo_password, mongo_auth_source, mongo_replica_set) at the first time and removing then in a future.

I agree. Similar to what we do in Orion, deprecating mongo CLI options in release 3.12.0 (but still supported) and removing definitively in a next version 4.0.0.

In this sense:

It's ok to remove that options from documentation (following the rule for deprecated features: "Documentation on deprecated features is removed from the repository documentation. Documentation is still available in the documentation set associated to older versions")
Recover the support to that options in the code. In the case of using the new mongo_uri setting, the old mongo_ options are ignored.
Add the following lines to CHANGES_NEXT_RELEASE

[cygnus-common][cygnus-ngsi] New setting mongo_uri (#2402)
[cygnus-common][cygnus-ngsi] Deprecate (mongo_hosts, mongo_username, mongo_password, mongo_auth_source, mongo_replica_set) (use mongo_uri instead)

kumardeepak5 commented 3 months ago

@AlvaroVega, @fgalan Please Review PR.

telefonicaid / fiware-cygnus

FIX - Replace MongoClientOptions to MongoClientUri in mongoClient of Mongo/STHSinks #2387 #2402