Not using `$schema_name_error_log`, using `$database_name_error_log` instead

telefonicaid / fiware-cygnus

A connector in charge of persisting context data sources into other third-party databases and storage systems, creating a historical view of the context

https://fiware-cygnus.rtfd.io/

GNU Affero General Public License v3.0

64 stars 105 forks source link

Not using `$schema_name_error_log`, using `$database_name_error_log` instead #2403

Open danielvillalbamota opened 2 weeks ago

danielvillalbamota commented 2 weeks ago

Description

The "..._error_log" table is not getting the name of the schema as documentation refers, but the name of database.

https://github.com/telefonicaid/fiware-cygnus/blob/808bf1fb5b3d1442686ac93646687728032bbda7/doc/cygnus-common/installation_and_administration_guide/error_persistance.md?plain=1#L21

How-to reproduce

This issue can be reproduced using a sink with datamodel dm-by-fixed-entity-type-database-schema.

Expected behavior

I would expect the table's name as documentation shows.

AlvaroVega commented 1 week ago

Current implementation is using:

https://github.com/telefonicaid/fiware-cygnus/blob/808bf1fb5b3d1442686ac93646687728032bbda7/cygnus-common/src/main/java/com/telefonica/iot/cygnus/backends/sql/SQLBackendImpl.java#L587-L593

schema + "." + dataBase + DEFAULT_ERROR_TABLE_SUFFIX;

So maybe documentation should be updated to reflect it

fgalan commented 1 week ago

PR #2404

@danielvillalbamota should this issue be closed?