search

telefonicaid / fiware-device-simulator

Simulator of FIWARE-compatible devices (UltraLight 2.0, JSON & NGSIv2)
GNU Affero General Public License v3.0
8 stars 13 forks source link

FIX negative values in random interpolator #72

Closed acoandre closed 4 years ago

acoandre commented 4 years ago

The randomLinearInterpolator fails to parse negative values.

Allow the optional sign in the regex matcher.

fgalan commented 4 years ago

Thanks for the contribution!

It seems that lint complains (see travis report):

lib/interpolators/randomLinearInterpolator.js: line 109, col 121, Line is too long.

Could you fix it, please?

In addition, please add an entry about the fix in the CHANGES_NEXT_RELEASE file. For instance:

- Fix: support negative values in random interpolator
acoandre commented 4 years ago

Lint should be satisfied now and a new entry is also added to CHANGES_NEXT_RELEASE.

But I am at a complete loss as to what Travis does not like this time, though this kind of error seems to have happened before.

fgalan commented 4 years ago

But I am at a complete loss as to what Travis does not like this time, though this kind of error seems to have happened before.

Sometimes some unit tests glitches. Re-run travis solve the issue, as this time.

Thanks!

fgalan commented 4 years ago

This is weird... I see a NOK mark in travis in the PR but if I go to the detail in travis page it seems to be ok:

imagen

Let's merge and see how it goes in master...

fgalan commented 4 years ago

Let's merge and see how it goes in master...

It worked :)

imagen