search

telefonicaid / fiware-orion

Context Broker and CEF building block for context data management, providing NGSI interfaces.
https://github.com/telefonicaid/fiware-orion/blob/master/doc/manuals/orion-api.md
GNU Affero General Public License v3.0
210 stars 265 forks source link

harness tests for orion::Area parsing #260

Open kzangeli opened 10 years ago

kzangeli commented 10 years ago

Description

xmlParseGeolocAreaCircleOk.test uses the log file to make sure everything works. This is no good, but there is nothing more to be done until the xml parser is fixed so that it returns parse error on unknown paths (coming soon). This harnesstest file was just a simple test and more are missing, but not before the parser (also the JSON parser) is fixed.

Missing harness tests:

xmlParseGeolocAreaCircleError.test xmlParseGeolocAreaPolygonOk.test xmlParseGeolocAreaPolygonError.test

jsonParseGeolocAreaCircleError.test jsonParseGeolocAreaCircleOk.test jsonParseGeolocAreaPolygonOk.test jsonParseGeolocAreaPolygonError.test

Effort: 4 man day

fgalan commented 10 years ago

I'd raise the priority to a higher value. I understand this issue need to be closed before merging feature/geoquery in develop.

kzangeli commented 10 years ago

Well, actually everything is already covered to 100% in unit tests, What is needed to implement correct tests of xml and json parsing is the 'feature' having the broker signal unknown fields returning parse error.

This improvement will come in another branch off develop (branch 'feature/complex_field_values'), I'm afraid, so unless we merge these two (area_parse is to be merged into 'feature/geoquery') branches before we merge the subtotal to develop, then yes, the issue should be closed before merging with develop. I don't see this issue as especially high priority (which is why I gave it a '4').