search

telefonicaid / fiware-orion

Context Broker and CEF building block for context data management, providing NGSI interfaces.
https://github.com/telefonicaid/fiware-orion/blob/master/doc/manuals/orion-api.md
GNU Affero General Public License v3.0
212 stars 265 forks source link

Use nc instead of GET /version in valgrind-broker-start #3201

Closed fgalan closed 6 years ago

fgalan commented 6 years ago

Raised at https://github.com/apinf/fiware-orion/pull/30#discussion_r193110610:

Better would be to use nc instead of GET /version inside 'valgrind-broker-start

.test should be adjusted, removing all the "orionCurl --url /version" that were added (in that PR and others before) just to make statistics work also when under valgrind.

fgalan commented 6 years ago

The touched tests should be checked for thinks like this:

 HTTP/1.1 200 OK
-Content-Length: 842
+Content-Length: REGEX((842|850))

removing the REGEX() in Content-Length and make it more deterministic

fgalan commented 6 years ago

... along with other REGEX() in the "orionCurl --url /admin/metrics" steps.

kzangeli commented 6 years ago

When the version request is removed from 'valgrind startup', all affected tests will fail under valgrind, so it will be easy to find them.

Actually ... no. Because of all those REGEX they will not fail ... Pity

fgalan commented 6 years ago

At least the .test touched by PR https://github.com/apinf/fiware-orion/pull/30 should be reviewed.

fgalan commented 6 years ago

Fixed by PR https://github.com/telefonicaid/fiware-orion/pull/3255