search

telefonicaid / fiware-sth-comet

A component of the FIWARE ecosystem in charge of managing historical and aggregated time series context information
https://fiware-sth-comet.rtfd.io
GNU Affero General Public License v3.0
27 stars 28 forks source link

Improved aggrMethod to accept multiple values #605

Closed Madhu1029 closed 5 days ago

Madhu1029 commented 1 year ago

Fixes #432 partially. aggrMethod can take multiple aggregations using comma separation.

Madhu1029 commented 1 year ago

Hi @fgalan ,

If PR seems ok, please merge the PR. Thanks

Madhu1029 commented 1 year ago

Hi @fgalan , I have updated the docs. Please merge this PR if it seems ok.

Thanks

Madhu1029 commented 1 year ago

Hi @fgalan ,

I have updated all the suggestions mentioned by you in previous comment. I request you to please review the PR.

fgalan commented 1 year ago

Hi @fgalan ,

I have updated all the suggestions mentioned by you in previous comment. I request you to please review the PR.

Thanks for your contribution! We would have a look to the PR the soon as possible.

Madhu1029 commented 7 months ago

Hi @fgalan ,

Could you please have a look on this PR?

AlvaroVega commented 7 months ago

Is this a new feature or extends and modify a current one? Should documentation be updated ?

Madhu1029 commented 7 months ago

Is this a new feature or extends and modify a current one? Should documentation be updated ?

Hi @AlvaroVega , Thanks for your response. Currently, we can only specify single aggrMethod like aggrMethod=sum or aggrMethod=min but with this PR we can specify multiple aggrMethod in single go like aggrMethod=sum,min,max. In addition to this, aggrMethod=all will give all the aggregation method results in one go.

Documentation for this is already updated in this PR.

fgalan commented 5 days ago

@Madhu1029 thanks for your contribution! Sorry for the delay merging this PR :)