Open AlvaroVega opened 3 years ago
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
lib/services/iotaRedirector.js | 10 | 23 | 43.48% | ||
<!-- | Total: | 10 | 23 | 43.48% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
lib/services/iotaRedirector.js | 14 | 74.93% | ||
<!-- | Total: | 14 | --> |
Totals | |
---|---|
Change from base Build 949284276: | -1.3% |
Covered Lines: | 506 |
Relevant Lines: | 632 |
- IOTA_PROVIDER_URL=http://172.17.0.1:4061/kk3
Depends on this PR https://github.com/telefonicaid/iotagent-manager/pull/256 This PR should be merged after PR https://github.com/telefonicaid/iotagent-manager/pull/256
time=2021-09-22T15:48:20.727Z | lvl=WARN | corr=eeed4c39-33d8-440a-8d52-8922230167f9 | trans=eeed4c39-33d8-440a-8d52-8922230167f9 | op=IoTAManager.Redirector | from=n/a | srv=smartcity | subsrv=/problemas/masproblemas | msg=several statusCodes [200,400] and combinedResults {"count":0,"devices":[]}, redirecting for GET | comp=IoTAgentManager
When iotaRedirector retrieves several status codes from iotagents linke [200,200,400] then iotagentManager is responding with 400 error.
This PR tries to return the valid results retrieved by iotagent-manager instead just one error.
Related issue https://github.com/telefonicaid/iotagent-manager/issues/167
This PR overcomes https://github.com/telefonicaid/iotagent-manager/pull/249