Fix_for_OrionCB Payload loss

telefonicaid / iotagent-node-lib

Module to enable IoT Agent developers to build custom agents for their devices that can easily connect to NGSI Context Brokers

https://iotagent-node-lib.rtfd.io/

GNU Affero General Public License v3.0

60 stars 85 forks source link

Fix_for_OrionCB Payload loss #1408

Open KeshavSoni2511 opened 1 year ago

KeshavSoni2511 commented 1 year ago

Fix for issue #1407

KeshavSoni2511 commented 1 year ago

Gentle Reminder!

mapedraza commented 1 year ago

Did you test yourself if it works? I do not think so... Anyway, a tests verifying this new behaviour, together with the documentation are required.

mapedraza commented 1 year ago

As @fgalan mentioned, this PR as it is right now is not the best way to implement CB retries, as the got driver implements retry options. The best is to wire those options (right now is disabled)

Some test cases should be implemented, reflecting a failling connection and working after some retries.

This should be configured as per device group, since the CB is also configurable at device group.