search

telefonicaid / iotagent-node-lib

Module to enable IoT Agent developers to build custom agents for their devices that can easily connect to NGSI Context Brokers
https://iotagent-node-lib.rtfd.io/
GNU Affero General Public License v3.0
60 stars 85 forks source link

remove depecated features: appendMode and bidirecciontal plugin (for 3.3.0+) #1413

Closed AlvaroVega closed 12 months ago

AlvaroVega commented 1 year ago

Component

Techdeb

Is your feature request related to a problem? Please describe

No response

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

The systemd version you checked that didn't have the feature you are asking for

No response

AlvaroVega commented 1 year ago

The following code will be removed:

https://github.com/telefonicaid/iotagent-node-lib/blob/4d7c824505a527ff76e4474d5d508d6e5445c19b/lib/services/devices/devices-NGSI-v2.js#L73-L102

https://github.com/telefonicaid/iotagent-node-lib/blob/4d7c824505a527ff76e4474d5d508d6e5445c19b/lib/services/devices/devices-NGSI-v2.js#L202-L258

AlvaroVega commented 1 year ago

related https://github.com/telefonicaid/iotagent-node-lib/pull/1416

AlvaroVega commented 1 year ago

related with works done in https://github.com/telefonicaid/iotagent-node-lib/pull/1390 Maybe some works in ngisld stuff should be done (do not use appendMode=false, do not relieson initial entity...)

mapedraza commented 1 year ago

@jason-fox there are some changes applied recently to IoTA that also affects to NGSI-LD side

For your information, as you can see from the issue title, we are going to remove bidirectional attributes in next release (3.4.0) in order to remove legacy code related with plugins architecture. In the future, subscription based commands will be added in a proper way.

For that reason, I think it is important to validate all the NGSI-LD functionality at 3.3.0

fgalan commented 12 months ago

Fixed by PR https://github.com/telefonicaid/iotagent-node-lib/pull/1421