Device and Group datamodels used in API requests differ from data models used internally or in MongoDB

telefonicaid / iotagent-node-lib

Module to enable IoT Agent developers to build custom agents for their devices that can easily connect to NGSI Context Brokers

https://iotagent-node-lib.rtfd.io/

GNU Affero General Public License v3.0

60 stars 88 forks source link

Device and Group datamodels used in API requests differ from data models used internally or in MongoDB #1587

Open AlvaroVega opened 8 months ago

AlvaroVega commented 8 months ago

IoT Agent Node Lib version the issue has been seen with

1.X, 2.X, 3.X

Bound or port used (API interaction)

Other

NGSI version

NGSIv2

Are you running a container?

None

Image type

None

Expected behaviour you didn't see

I.E:

Attributes are stored into mongo DB as active but in Group and Device model are called attributes
Groups are managed internally (and not only into the as services (refer to PR #1648 and Issue #1649 )

All datamodels used across codebase, API requests and DB models should be homogeneus

AlvaroVega commented 8 months ago

We should review doc about ensure API s properly described. Possibly a db script update should be needed to solve this issue if finally should be fixed.

Madhu1029 commented 6 months ago

Hi @AlvaroVega ,

Could you please explain this issue in detail? I want to work on this issue.

AlvaroVega commented 6 months ago

Hi @AlvaroVega ,

Could you please explain this issue in detail? I want to work on this issue.

Not sure if this is the best issue to implement now, since implements changes in database (mongo) model and has some impact in current production deploys.

fgalan commented 2 months ago

As part of this issue, analyze which exact adaptations are needed.

The final objective is that API, code and DB model get aligned (code-API adaptation is also mentioned here).

fgalan commented 2 months ago

Maybe both #1649 and this issue should be addressed together.