search

telefonicaid / iotagent-node-lib

Module to enable IoT Agent developers to build custom agents for their devices that can easily connect to NGSI Context Brokers
https://iotagent-node-lib.rtfd.io/
GNU Affero General Public License v3.0
58 stars 84 forks source link

fixed for the issue #1524 #1611

Open vivekNEC opened 1 month ago

vivekNEC commented 1 month ago

fixed #1524

AlvaroVega commented 1 month ago

@vivekNEC Thanks for your great contribution. I would like this PR should contain a tests (maybe a functional test) which raises the bug and then show how this PR is fixing the bug. Maybe @Madhu-NEC could contribute it

fgalan commented 1 month ago

In addition to @AlvaroVega comment, please add an entry in CHANGES_NEXT_RELEASES describing the fix done by this PR. Suggestion:

- Fix: autoprovison now working with resources diferent from defaultResource (#1524)
vivekNEC commented 1 month ago

Hi @AlvaroVega is there any existing test cases related to service autoprovision that I could use as a reference. If there are any, could you please point me in the right direction?

mapedraza commented 1 month ago

Hi @AlvaroVega is there any existing test cases related to service autoprovision that I could use as a reference. If there are any, could you please point me in the right direction?

If you find in the repo you will find several examples like the following one: https://github.com/telefonicaid/iotagent-node-lib/blob/f7b914c541aa75a3604c6665ca0113411b39b971/test/unit/ngsiv2/ngsiService/active-devices-test.js#L904

AlvaroVega commented 1 month ago

Hi @AlvaroVega is there any existing test cases related to service autoprovision that I could use as a reference. If there are any, could you please point me in the right direction?

I was thinking about something like https://github.com/telefonicaid/iotagent-node-lib/blob/f7b914c541aa75a3604c6665ca0113411b39b971/test/functional/testCases.js#L182