search

telefonicaid / iotagent-ul

IoT Agent for a UltraLight 2.0 based protocol (with HTTP, MQTT and AMQP transports)
https://fiware-iotagent-ul.rtfd.io/
GNU Affero General Public License v3.0
37 stars 55 forks source link

Fix-for-binary-data-representation-when-sending-data-through-HTTP-#601 #603

Closed MayankSingh-NEC closed 1 year ago

MayankSingh-NEC commented 1 year ago

This PR fixes the issue https://github.com/telefonicaid/iotagent-ul/issues/601

fgalan commented 1 year ago

imagen

19 commits in less than an hour!

Next time please try to "package" all your changes in the same commit to avoid noise.

MayankSingh-NEC commented 1 year ago

Hi @mapedraza , here the test cases that are failing, which are known from the point of code fix. Failing UTs, e.g. In a value given as Date&Time, None, Boolean or any string values.

Need your guidance for these failed UTs. How we can manage to pass all test cases? Convert all the values into hex string?

mapedraza commented 1 year ago

Hi @MayankSingh-NEC

After a deep dive into the agent and previous functionality implementation, this agent (UL) is not supporting binary data representation:

https://github.com/telefonicaid/iotagent-json/pull/667#issuecomment-1141804315

So this PR and issue #601 can be closed