search

telefonicaid / netphony-network-protocols

Java Library of Networking Protocols: PCEP, RSVP-TE, OSPF, BGP-LS
Apache License 2.0
42 stars 19 forks source link

Create JUnit Tests for BGP-LS Messages, objects and TLVs #4

Closed oscargdd closed 3 years ago

oscargdd commented 8 years ago

Added tests for BGP-LS MP Reach Attributes with Node NLRI. Pending tests with Link NLRI

lixisha commented 7 years ago

Hello, i'm very interested in netphony-network-protocols library. I have tried some example about creating BGP-LS packet, but when i use the Wireshark to capture the packet, I found a 'Continuation' field which is 29 bytes. I wonder about what it is Could you explain it for me ? Thank you very much!

oscargdd commented 7 years ago

Hi! Can you send the sample code and the pcap trace, so I can take a look at that field?

lixisha commented 7 years ago

Thank you for your response!

Please check the attachment about pcap trace. I used netty library 3.9

Thank you very much!

Regards,

Li, Xisha Supervised by professor Jin Seek Choi. MIR Lab. Department of Computer Science and Engineering Hanyang University Seoul, KOREA 133-791 +82-010-8285-8911 wiresharkAndCode.zip

oscargdd commented 7 years ago

I have opened the pcap trace in wireshark and it looks good. Here is the screenshot: wireshark_update_dissection hot.

oscargdd commented 7 years ago

I saw it... it appeard before the UPDATE message.. Let me check... first time to see it ,
continuation

lixisha commented 7 years ago

It seems like that the BGP-LS format is correct.Maybe there is something wrong with the wireshark dissector?ps: I have used netty (version 3.10.5.final) with ObjectEncoder/ObjectDecoder to test the library.Regards,Li, XishaSupervised by professor Jin Seek Choi.MIR Lab. Department of Computer Science and EngineeringHanyang UniversitySeoul, KOREA 133-791+82-010-8285-8911 ------ Original Message ------ Date: Friday, Mar 3, 2017 09:11:50 PM From: "Óscar González de Dios" notifications@github.com To: "telefonicaid/netphony-network-protocols" netphony-network-protocols@noreply.github.com Cc: "lixisha" lixisha@nate.com, "Comment" comment@noreply.github.com Subject: Re: [telefonicaid/netphony-network-protocols] Create JUnit Tests for BGP-LS Messages, objects and TLVs (#4)

I saw it... it appeard before the UPDATE message.. Let me check... first time to see it ,

—You are receiving this because you commented.Reply to this email directly, view it on GitHub, or mute the thread.

 

oscargdd commented 7 years ago

The problem I see in you traces is that, in every packet sent, before the BGP-LS packet there are a set of bytes sent, always the same. You need to check what are you sending in your java code. Once you have enconded the message, you have the bytes to be sent. Check the number of bytes (or even print them) and compare against what you are capturing in wireshark. Maybe there is something in your code sending some bytes before every packet...