telega1 / fastdial

Visual bookmarks addon for Firefox.
3 stars 0 forks source link

favicons loading bug on 4.9 #8

Closed ghost closed 11 years ago

ghost commented 11 years ago

I think i found a bug, Looks like the favicons reload every time i open fastdial, so it takes too much time loading because i have 24 webpages and 4 folders (7x4), i have the favicons disabled on the options because i use userlogos for my webpages but the favicons still reload even if they are hidden.

If is not a bug can you please make a option to disable the favicons reload.

Meanwhile i edited fast_dial-4.9-fx.xpi and removed "getFavicon(i)" from "fastdial.html" and the loading is instantaneous again :)

Cheers.

telega1 commented 11 years ago

I have modified the way icons data is retrieved, could you try version 4.10 from here: http://www.userlogos.org/files/fastdial-4.10-fx.xpi - does it suffer from the same problem?

ghost commented 11 years ago

Nice, looks like it's fixed, but now there is another bug, the adress bar shows "chrome://fastdial/content/fastdial.html?folder=###" when you enter a folder and is preselected by default(It has the blue "selected text" look), the text on the adress bar on the home is hidden but is preselected too (i can see the text cursor blinking)

telega1 commented 11 years ago

I thought some people want to enter something into address bar, so I added selecting the address bar. Do you think this isn't needed?

ghost commented 11 years ago

Well, on my end is distracting because of my windows theme and my personas, but you are right, many people wanted the search feature back, at least could you fix the folders (the adressbar text is not being deleted) so it is not distracting anymore :) (the blue selected text contrast too much with my theme)

telega1 commented 11 years ago

Please try re-downloading version 4.10, I have updated it. What do you mean "people wanted the search feature back"?

ghost commented 11 years ago

I think it had a search feature very back then, i seen post of it being deleted because of incompatibility, i could be wrong

telega1 commented 11 years ago

Sorry, I don't understand. Do you mean Fast Dial search function? If yes, then it is enabled by adding search boxes by increasing "Search" option in Preferences. Then several search boxes appear on top of Fast Dial page. The reason of selecting the address bar was to allow a person to enter some URL manually, not clicking on a dial.

ghost commented 11 years ago

Oh i did't know that, your idea about entering the url i think is correct, but as i said before the adress bar text on the folders is no being deleted, so its distracting on my end to have the selected text, the fastdial home was correct on the previous 4.10 before you removed the feature (No text, just the blinking cursor)

telega1 commented 11 years ago

I have removed text selection on folders. Does it work OK now?

ghost commented 11 years ago

Does not seem to be changes from the latest version that does not have the feature (4.10.2 i guess?) They have the same MD5: 658CACCA8A84B113B6F26E34B39DB665

i'm supposed to use another link?

Btw i'm on Firefox Nightly 25.0a1

telega1 commented 11 years ago

If the folder url is no more selected when going to folder, then this is the correct version. Blinking cursor in the address bar on opening new tab is OK.

ghost commented 11 years ago

i mean you forgot to upload the new xpi, is still the one that does not have the "address bar selected" feature you wanted to add, i cleared my cache but still is the same xpi, the one from the 6th comment. Or maybe you mean you removed the address bar selected feature, if that is then is ok.

telega1 commented 11 years ago

You said that having "chrome://fastdial/content/fastdial.html?folder=XXX" in blue doesn't look good. I agreed with you and disabled this behavior. So it should be no more in blue.

ghost commented 11 years ago

Hehehe, I hope i didn't bugged you too much :), thank you very much for maintaining this awesome extension :D.

telega1 commented 11 years ago

Not at all, thank you for the useful feedback.