telegramdesktop / tdesktop

Telegram Desktop messaging app
https://desktop.telegram.org/
Other
25.97k stars 5.15k forks source link

[Feature request] Ability to disable integrated photo viewer #1111

Open matejdro opened 9 years ago

matejdro commented 9 years ago

When you receive images from chat (either sent as image or as file), they are displayed in integrated photo viewer.

This viewer lacks zoom and other functionality that is present in other photo viewers. So if I want this functionality I must right click on the image, select "View in folder" and then open file manually from file browser.

There should be an option to disable integrated viewer and open my default image viewer when I click on the image in chat.

auchri commented 9 years ago

Zoom with ctrl and +/-

matejdro commented 9 years ago

Oh wow I didn't even tried it. Why wouldn't you support mouse scroll wheel zoom?

joshsleeper commented 8 years ago

Agreed. Ctrl +/- works, but mouse-wheel zoom is much more intuitive, especially when people usually open images in the viewer with a mouse click, not keyboard input. Since we use the mouse to open and close images, should use the mouse for most image interaction.

Aokromes commented 7 years ago

you can do mouse wheel zoom now.

Aokromes commented 4 years ago

now we have https://github.com/telegramdesktop/tdesktop/commit/54c409d967f9e823afdb8d9f94d775074c284aa0 maybe it can be improved to include photo viewers / audio players, etc without being hidden setting.

kirsan31 commented 4 years ago

now we have 54c409d maybe it can be improved to include photo viewers / audio players, etc without being hidden setting.

This simple PR works only with downloaded (on disk as video file) video. In theory same must go with photos, but in practice in TD there are no downloaded (in same therms as video) photo :( This button: image

always download photo and save it with new name. So, with photo it's of course doable, but not so simple as with video...

stale[bot] commented 3 years ago

Hey there!

This issue will be automatically closed in 7 days if there would be no activity. We therefore assume that the user has lost interest or resolved the problem on their own.

Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

matejdro commented 3 years ago

We are still interested in this.

stale[bot] commented 3 years ago

Hey there!

This issue was inactive for a long time and will be automatically closed in 30 days if there isn't any further activity. We therefore assume that the user has lost interest or resolved the problem on their own.

Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

kirsan31 commented 3 years ago

Still actual.

qsmodo commented 3 years ago

Zoom works but there is no way to scroll the image (e.g. to see a detail in a corner) as far as I can tell. Saving the picture and opening it in an external viewer calls for a bunch of clicks and context-switching.

Photon89 commented 2 years ago

Other file types have an "Open with" and "Show in folder" options in the context menu, even images which have been sent as a file do. It seems like a minor thing to add these options to the context menu for images as well. Would be great, if this could be fixed! :smiley:

john-preston commented 2 years ago

@qsmodo You can zoom and then drag the image by mouse, looking to all parts of it with zoom in.

Photon89 commented 2 years ago

Just for completeness, in my case I need to view the image and use the chat simultaneously which is not possible because the integrated image viewer blocks the chat.

kirsan31 commented 2 years ago

Just for completeness, in my case I need to view the image and use the chat simultaneously which is not possible because the integrated image viewer blocks the chat.

This is a bit different issue: https://github.com/telegramdesktop/tdesktop/issues/1710

john-preston commented 2 years ago

@Photon89 It's not that simple, because when photos are downloaded they're not saved as a regular files on disk (so nothing can be opened in the external viewer). They're saved in an encrypted local storage only. And only after manually saving them to system Downloads they're materialized as real jpg files on disk.

Photon89 commented 2 years ago

@kirsan31 Not sure, even if the viewer wouldn't go to full screen, which is the issue #1710, it most probably would still block the chat portion of the Telegram window. So using the chat and viewing the image simultaneously would still be impossible.

@john-preston I see, thanks for the explanation! But I don't quite understand: This seems to be some security related feature, right? So the sender of the image chooses that the image should not be saved on the receiver's disk but only in an encrypted local storage. But this feature doesn't really work, if the receiver can still select to save the file on disk.

What would make more sense to me, would be: Give the sender two options: "Send encrypted" and "Send without encryption". For the first option, remove the possibility to save the screenshot on disk completely; for the second option save the file on disk without encryption (so it can be opened with an external viewer).

kirsan31 commented 2 years ago

IMHO, the best resolution here is to implement https://github.com/telegramdesktop/tdesktop/issues/1710 with ability to use chat in ||...

Photon89 commented 2 years ago

Well, an option to open the viewer in a new window, like the call dialogue, would mostly solve it for me (just would need to get used to the controls for zoom and shift in the integrated viewer). :smiley:

matejdro commented 2 years ago

It's not that simple, because when photos are downloaded they're not saved as a regular files on disk (so nothing can be opened in the external viewer). They're saved in an encrypted local storage only. And only after manually saving them to system Downloads they're materialized as real jpg files on disk.

I don't really see why would this be such an issue. When "Do not use internal photo viewer" option is enabled, Telegram would just use existing download code to materialize jpg immediately into OS's tmp folder and use also existing code to open that file with default application.

Photon89 commented 2 years ago

As far as I understand, the intention is that an encrypted image should not be decrypted (to protect sensitive information maybe) but this is not really given if the image can still be decrypted and saved on disk using the context menu...

matejdro commented 2 years ago

Right, but by enabling "Do not use internal photo viewer" I'm giving telegram explicit permission to decrypt my images (you could add a warning next to the setting I guess, but I don't really see this as a big security issue).

ilya-fedin commented 2 years ago

What @john-preston meant (I guess) is that it's implemented in a way that it's not saved to disk and it's hard to change that (read like "too much effort for such a low priority issue"), not that it's some security feature that require some question to decrypt images, it's not a secret chat or something, you can still save the file by a button in the viewer. Also, if a feature requires an option, it's a blocker in tdesktop. Adding options is not something @john-preston likes.

aljustiet commented 1 week ago

The same request