telegramdesktop / tdesktop

Telegram Desktop messaging app
https://desktop.telegram.org/
Other
25.92k stars 5.13k forks source link

Messages on the left side when fullscreen #1587

Closed AOmelaienko closed 8 years ago

AOmelaienko commented 8 years ago

Just. WHY.

diazbastian commented 8 years ago

I made a simple mockup with the idea that I proposed and may solve some problems. interested see #1652

Cheers

susnux commented 8 years ago

@techkid6 sorry but I will not do it. I tried it and think it is not so hard, but I have no chance to test it. The build system is so messed up, I had to replace a lot of path (I do not want that much static libraries, devs: Never heard of dynamic linking?) and then this:

#include <unity/unity/unity.h>

I have better things to do then to try to remove the unity dependencies only to get it build on my system. Sorry guys, if you want to go into it look for Adaptive::Wide() usage.

I hope the developers fix this issue, if not I will have to search for alternatives.

Walkman100 commented 8 years ago

for those new here that haven't read the whole conversation:

http://telegram-for-desktop.en.uptodown.com/windows/old https://github.com/Walkman100/TDesktop-Backups https://updates.tdesktop.com/tsetup/tsetup.0.9.18.exe

FlyingPumba commented 8 years ago

@Walkman100 thanks !! I couldn't find the linux-64 version of 0.9.18

FichteFoll commented 8 years ago

As an avid IRC user, I can relate to all messages being on the same side, but the one thing that annoys me regarding this change is personal (not group) conversation where both parties have their messages on the same side despite certainly on opposite sides of the conversation. And the fact that the width that switches the view seems so arbitrary. (I was 10px beyond the threshold with my window.)

I suggest the following:

  1. Make the "own messages on right side" option configurable for private and group chats individually
  2. Display messages in a centerered block always, like in @telegramdesktop's second image in this comment: https://github.com/telegramdesktop/tdesktop/issues/1587#issuecomment-181857319
  3. For "own msg on right", limit the width of this message block to 2x or 3x individual message width, by default. For all on left side this would obviously just be the message width.
  4. Optionally make the individual message width and message block width configurable (maybe though some advanced configs, e.g. FireFox's about:config or a .txt file)

mockup:

+-----+--------------------+
|     |      +--+          |
|     |           +-+      |
|     |      +--+          |
|     |      |  |          |
|     |      +--+          |
|     |      +--+          |
|     |         ==         |
|     |          +--+      |
|     |          |  |      |
|     |          +--+      |
|     +--------------------+
+-----+--------------------+

Here's an example of how whatsapp web looks on my WQHD display:

2016-02-20_17 58 28

diazbastian commented 8 years ago

@FichteFoll Hi, I am also IRC user. I have some doubts about your proposal, Telegram web does something similar (except bubble messages) and seems a good idea, but then, why a user maximize window TDesktop? Thus, it would be like to use TDesktop with a smaller window.

Cheers

UnAfraid commented 8 years ago

I am use to maximize all applications, including Telegram everything looks good on 1080p. And now since the last changes half of my screen is completely unusable, i'd like to see this option to choose old layout or soon i'll downgrade to the older release where it was better.

brawaru commented 8 years ago

@telegramdesktop, what you think about adding file with message layouts for user (non hardcoded). Example:

// messages.json
{
  "message-layouts": {
    "centered": {
      "full-size": {
        "positions": {
          "incoming": "left",
          "date": "center",
          "info": "center",
          "outgoing": "right"
        },
        "padding": {
          "left": "125px",
          "right": "125px"
        }
      },
      "<700px": {
        "positions": {
          "incoming": "left",
          "date": "center",
          "info": "center",
          "outgoing": "right"
        } ...

Full JSON

zoharlevin commented 8 years ago

this needs to be changed back or given an option to choose. doesn't make sense that i should be minimizing to the exact moment when the messages look normal again, just to be able to use telegram and not get pissed off. it looked totally fine to me before this ridiculous change.

marcovr commented 8 years ago

Hey guys, finally some good news! Looks like the long awaited checkbox is coming. fc9d75b4f01fed32f3b4d5827ac47c5724ea5787

telegramdesktop commented 8 years ago

Please check out the latest 0.9.25 dev version from the bottom of this page:

https://desktop.telegram.org/#dev-version

It adds a checkbox "Adaptive layout for wide screens" below "Tile background" checkbox that can disable the new layout. It is visible only if you have a large window (with the new layout) already.

legorian commented 8 years ago

Thanks a lot! Having one of those laptops with a screen at a 1366x768 resolution that with only a small viewing angle makes the green bubbles almost white, and sometimes icons looking too similar at first glance, this makes my life much easier again. It was a hassle to always find the maximum width of the window, instead of just bringing it to full screen. Keep up the good work!

emadgh commented 8 years ago

Hi, I really loved the new style, all in one side , that's really easy to read messages, Seems in 0.9.26 you changed it for screens that are bigger than 1366 :disappointed:

It would be really good if you could make it optional if the user always want it or just adaptive. eg.

image

Thank You

ghost commented 8 years ago

Wow this change really made some users unhappy. I feel as a developer you shouldn't be forcing users to use the format you feel is best for them, since well we are the ones using it.

I prefer the centered, but just make it optional. It doesn't even take that much effort on the developers side. Same as the dark theme that was forked. The work has already been done. Just implement it.

z3ntu commented 7 years ago

Uhm... Question: Does this option still exist in v0.10.19 ? I can't find it anymore...

Pablohn26 commented 7 years ago

@z3ntu yes it does

selection_720

gilbertw1 commented 7 years ago

@z3ntu: the option only seems show up if the current window is high enough resolution for the adaptive layout to kick in.

z3ntu commented 7 years ago

Wow... That's really weird/bad behavior to show options based on the window size...

PandorasFox commented 7 years ago

Not entirely. Ideally it'd be grayed out and have a tooltip/explanation why, but it's better than a nonfunctional checkbox.

gilbertw1 commented 7 years ago

To be fair, I do think it is pretty poor behavior. I normally set this option as part of my install process, however I have to wait until the window is large enough on a particular screen to change the setting. I think it'd be even worse to show the option and not allow the user to change it.

I can't really think of any precedent for this behavior and can only imagine the devs are worried about the option confusing users who don't have the window large enough to trigger the adaptive layout.

Updating to a new version via the arch user repository regularly triggers a re-login requiring me to reconfigure my settings, and having to wait until a arbitrary condition is met to change a setting I want set everytime is a consistent source of frustration.

A similar analog would be an SSL enabled option that you couldn't set in app until you were already connected to the internet. If you're setting the app up offline the option is nowhere to be found. However, once your online and can now toggle the setting, the app has already connected insecurely. The stakes aren't as high here, but the user interaction is equally as poor.

fsolatan212 commented 7 years ago

is there an easy way to increase the width of the left column with list of chats in Telegram Web? I need less space for the messages, but more space for the list and summary. I'm using Chrome on PC.

stek29 commented 7 years ago

@fsolatan212 why the hell are you spamming with this question here?

fsolatan212 commented 7 years ago

I just asked a question, I'm not spamming. if you don't want to answer, just ignore, otherwise it's a problem that I have and need the answer.

On Thu, Dec 22, 2016 at 10:10 AM, Viktor Oreshkin notifications@github.com wrote:

@fsolatan212 https://github.com/fsolatan212 why the hell are you spamming with this question here?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/telegramdesktop/tdesktop/issues/1587#issuecomment-268818811, or mute the thread https://github.com/notifications/unsubscribe-auth/AXjwIDwCFh49UyPOMtPQHg-kBw4xe5aXks5rKpLLgaJpZM4HWXIU .

PandorasFox commented 7 years ago

The proper place to ask would be on the webogram repo, or on one of its forks' repos, and not here.

stek29 commented 7 years ago

@fsolatan212 1) You're asking at wrong project report 2) You've asked it already at Webogram repo, but asked in other places too without even waiting for answer

mklishevych commented 7 years ago

It's funny that telegram considers my 13" macbook as 'wide screen'... Just updated to latest version (1.0.2) and suddenly my messages moved to the left. Already found an option in preferences to disable that, but you should probably reconsider screen sizes that fall into 'wide screen' category.

scorchio commented 7 years ago

@telegramdesktop wrote that

I still can't understand why anyone on earth uses large (or even fullscreen) window for Telegram Desktop

Personally I use Telegram in fullscreen most of the time; I prefer to have a kind of "distraction free" environment for chatting. I realize this is very subjective, but probably a lot of other people are doing the same and it would be nice to know how the application is actually used. This raises a question: do you have any kind of statistics on the window size vs. resolution of the Telegram application? (If you don't want to collect information like that in the application, you could do polls or whatever.)

johan-wq commented 7 years ago

I use Telegram full screen on a large screen most of the time. And I HATE having all the chat on one side. I know what I typed - I don't want that to get in the way when I'm reading. If I do want to know what I typed, I want that easily accessible instead - by having it far off to the right.

Now, what i do want is a bar to the right with my stickers since I use them all the time.

OnkelTem commented 6 years ago

Guys, it's impossible to grasp and the topic, so let me just ask: how to make the message area to allocate 100% width? I just don't get why it's not set like that by default. If I need a smaller width - I would just make the window narrower.

stek29 commented 6 years ago

@OnkelTem You can't now.

Full width is almost never used together with message "bubbles". Maybe one day TDesktop would have bubble-less option, which would also take 100% width.

Anyway it has nothing to do with this issue. It's closer to #2060 I think.

I'm locking the issue. Just a recap for anyone who stumbles into it: there's a setting which is shown when bubbles are on left side and it allows to disable this behavior. It's labeled "Adaptive layout for wide screens".