search

telegramdesktop / tdesktop

Telegram Desktop messaging app
https://desktop.telegram.org/
Other
26.2k stars 5.2k forks source link

Tiled background is being enabled after every auto-update #16468

Closed yurikoles closed 1 year ago

yurikoles commented 3 years ago

Steps to reproduce

  1. Setup some chat background.
  2. Disable background tiling.
  3. Apply in-app update.

Expected behaviour

Tile background setting should be preserved.

Actual behaviour

Tile background is keeping enabled after every in-app update.

Configuration

Operating system: macOS from 10.15 (Catalina) through 12.0 (Monterey). Windows 10 and 11.

Version of Telegram Desktop: Still an issue in 2.7.9, but I observe this for at least one year.

Used theme: Tinted.

yurikoles commented 3 years ago

I can confirm this on Windows 10 and 11.

cyberpunkrocker-zero commented 2 years ago

It is still happening on telegram-desktop-3.2.3, on Arch Linux... This is getting really annoying. I need to uncheck the 'Chat backround > Tile backgound'-setting every f*****g time there's an update.

woomiez commented 2 years ago

It seems that every update inverts this setting. I'm on Win10, and use a tiled chat background, and after every update TDesktop reverts this to a stretched instead of tiled background.

lordrex34 commented 2 years ago

This is a really annoying issue. I can confirm the same here.

d1vanov commented 2 years ago

Same for me, very annoying really.

john-preston commented 2 years ago

@yurikoles @cyberpunkrocker-zero which wallpaper are you using that gets the "Tile background" enabled after an update?

Also, can anybody reproduce that on a fresh install? Like, on Windows download some older portable version from https://github.com/telegramdesktop/tdesktop/releases unpack it to a clean folder and try to reproduce the bug.

Is it reproducible on a freshly unpacked old->to->new version?

cyberpunkrocker-zero commented 2 years ago

@john-preston different wallpaper on different machines (desktop/laptop), and always one of my own images, never used any builtin one. Besides, I haven't noticed this happening recently any more, say, since about the introducion of 3.4.x series (currently using 3.5.0)

john-preston commented 2 years ago

So, each time it was a custom chat background ("Choose image..." etc) and it was resetting from non-tiled to tiled?

I need details and reproduction steps because I suppose it is happening because of some legacy settings not being completely wiped / ignored after an update and they keep being read. There is very complex logic in migrating old settings to new settings when it comes to theming / chat background, because the things there changed significantly several times in the last several years.

cyberpunkrocker-zero commented 2 years ago

So, each time it was a custom chat background ("Choose image..." etc) and it was resetting from non-tiled to tiled?

That's correct.

woomiez commented 2 years ago

In my case, I have the same background image (own one) on both Android and desktop (Win10), and it keeps happening on all updates, including the most recent a few days ago. for some reason, I also have this background image in the chat background chooser about 50 times.. so it seems to create a new theme entry each time I switch back to tiled..

laikoni commented 2 years ago

For me the issue also happens with one of the default images (Choose from gallery) as background, with the 'blurred' option enabled. (Telegram Desktop on Windows 10)

john-preston commented 2 years ago

@woomiez Ok, looks like it uploads each time as a new cloud background. For you it is resetting from tiled to non-tiled, right? (not like the previous reporter)

If you're on Windows:

Can you please check if it reproduces on a fresh portable version from a clean folder? Like, download portable version 3.5.0:

https://github.com/telegramdesktop/tdesktop/releases/download/v3.5.0/tportable-x64.3.5.0.zip

log in, set the desired background and try to autoupdate the app (it should update to 3.5.1), will the problem be reproduced?

john-preston commented 2 years ago

@laikoni Can you provide details: which image exactly (there are mostly cloud-synced backgrounds, but there are some hard-coded to the binary with completely different handling in code), and do you try to keep it tiled / non-tiled and what value you get after the autoupdate?

Also, please check if it is reproduced on a fresh portable version from a clean folder, like I've described in the comment above.

woomiez commented 2 years ago

@woomiez Ok, looks like it uploads each time as a new cloud background. For you it is resetting from tiled to non-tiled, right? (not like the previous reporter)

yes. I want it tiled, and it resets to stretched.

If you're on Windows: Can you please check if it reproduces on a fresh portable version from a clean folder? Like, download portable version 3.5.0:

https://github.com/telegramdesktop/tdesktop/releases/download/v3.5.0/tportable-x64.3.5.0.zip

log in, set the desired background and try to autoupdate the app (it should update to 3.5.1), will the problem be reproduced?

I have done that, and the problem did not occur there.

gordogato81 commented 2 years ago

This issue has returned for me on telegram 3.6.1 Windows 10. It does not appear to be present on Android v8.6.1 (2594) arm64-v8a.

Steps to reproduce:

  1. Upload custom wallpaper from file
  2. Settings -> Chat Settings -> Uncheck tile option under chat background
  3. Apply update
GideonUng commented 2 years ago

lol why is this still an issue?

agent-guardian commented 2 years ago

This is still happening for me

k-kruglov commented 2 years ago

Happens on Windows 10, 4.2.4. x64.

7nik commented 1 year ago

This still happens on 4.3.1, annoying

ilya-fedin commented 1 year ago

It seems #5944 is mostly about this, so this apparently should be closed as a duplicate to have "still happens" messages in only one place.

john-preston commented 1 year ago

Please check by updating 4.5.1 to 4.5.2.