search

telegramdesktop / tdesktop

Telegram Desktop messaging app
https://desktop.telegram.org/
Other
25.44k stars 5.05k forks source link

Telegram Desktop reports its audio stream's client name as "telegram-desktop" #17232

Closed ratijas closed 2 years ago

ratijas commented 2 years ago

Steps to reproduce

  1. Play music in any Telegram chat / channel, or make a call

Expected behaviour

Pipewire / PulseAudio audio stream should be registered with a client name of the app, as displayed on a task panel etc.: "Telegram Desktop", capitalized and spaced nicely.

For example, Elisa music player does this by providing Qt's app name to libVLC: https://invent.kde.org/multimedia/elisa/-/merge_requests/296/diffs

Actual behaviour

It's just a binary's name: "telegram-desktop".

KDE/Plasma Audio Volume applet: Audio Volume

System Settings Audio KCM: System Settings

Operating system

Arch Linux

Version of Telegram Desktop

3.2.3-1

Installation source

Other (unofficial) source

Logs

No response

ilya-fedin commented 2 years ago

tdesktop doesn't use PA API directly, it uses cross-platform OpenAL library and it doesn't provide such API. This is not possible to implement and I think this is not even a bug (this can be a feature request, but still, I don't see a way to implement this).

ratijas commented 2 years ago

In that case, it's not "Closed", it's "Blocked by upstream". Please, consider reopening.

I'm not familiar with neither audio subsystem, but I'll try my best open a new issue is a more relevant place for now.

ilya-fedin commented 2 years ago

I don't think there's any reason to have an issue open while nothing can be done. When this would be possible, you can create a new one. But it still would need to be a feature request, not a bug report.

ratijas commented 2 years ago

Well, just for tracking purposes.

You are free and welcome to change this issue's category at will :)

ilya-fedin commented 2 years ago

Well, I don't think we really need to track it here

And I don't have rights to change issue title, nor @Aokromes has. So it's up to you :)

ratijas commented 2 years ago

Nah, can't modify labels either. It was assigned as a part of a template.

ilya-fedin commented 2 years ago

I'm not familiar with neither audio subsystem, but I'll try my best open a new issue is a more relevant place for now.

IIRC, libpulse tries to read app name from PULSE_PROP environment variables and glib application name, but openal sets binary name as app name forcefully. I remember I've sent them a PR a while ago fixing this, they merged it, but there were no releases so far, so it's likely it just haven't reached your distribution. So, the relevant place is your distro bugtracker, to backport my commit.

ratijas commented 2 years ago

there were no releases so far, so it's likely it just haven't reached your distribution. So, the relevant place is your distro bugtracker, to backport my commit.

On Arch Linux it matches the latest tag in the repository, 4th February

openal: 1.21.1-1

https://github.com/kcat/openal-soft/tags

ilya-fedin commented 2 years ago

As I just said, my commit is after the latest release (tag)

ratijas commented 2 years ago

Oh I see https://github.com/kcat/openal-soft/pull/543

It's gonna be not earlier than Christmas, heh

ilya-fedin commented 2 years ago

Official binary and snap cherry-pick this commit, though