telegramdesktop / tdesktop

Telegram Desktop messaging app
https://desktop.telegram.org/
Other
26.18k stars 5.19k forks source link

Hamburger menu button without folders column does not respect Fitts' Law #17423

Closed ratijas closed 1 year ago

ratijas commented 2 years ago

Steps to reproduce

  1. Open Telegram, create or login into your account.
  2. Do not create (and remove if any) folders (chat groups).
  3. Now that the main view has no Folders column, the hamburger / sidebar button becomes a circle in a square area on the left of a search bar.
  4. Click in the corner of a Window

Expected result: Hamburger menu opens.

Actual result: Nothing happens, because the target area of this button does not stretch all of the corner area that it could. It can be seen by its Material design's ripple background.

  1. Now, add/create at least one Folder.
  2. Click in the corner

Expected result: Same. Hamburger menu should open up.

Actual result: It actually opens. Since Folders column appears in the main view, the sidebar/hamburger button becomes a rectangle that covers the entire top left area of the view.

Expected behaviour

Menu button should always respect Fitts' law.

Actual behaviour

It does not clikk in the corner.

Operating system

Arch Linux, KDE/Plasma (although, irrelevant)

Version of Telegram Desktop

3.3.0-1

Installation source

Other (unofficial) source

Logs

No response

ratijas commented 2 years ago
Description No folders With folders
Normal no folders - normal with folders - normal
Pressed no folders - pressed with folders - pressed

(Unfortunately, GitHub doesn't show inline videos in a table)

https://user-images.githubusercontent.com/6737986/147418688-bf5944f6-12cd-4f9f-bd82-53dabcf18964.mp4

https://user-images.githubusercontent.com/6737986/147418698-6b30c973-f8bb-40cf-8cbf-fba459169d2b.mp4

ratijas commented 2 years ago

Actually, just noticed: Back arrow button in chat views etc. suffers from this very same problem too.

What's wrong with them all? Looking like a circle is fine and all, but why should their hitbox be constrained because of it? I mean, the circle background is not even visible, until the button is pressed, and its ripple animation completed. It just does not make any sense. You click somewhere which looks like a on or very near the icon — and might get a hit or not, 50/50. That's just not reasonable.

stale[bot] commented 2 years ago

Hey there!

This issue was inactive for a long time and will be automatically closed in 30 days if there isn't any further activity. We therefore assume that the user has lost interest or resolved the problem on their own.

Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

ratijas commented 2 years ago

This issue is still annoyingly relevant

github-actions[bot] commented 1 year ago

Hey there!

This issue was inactive for a long time and will be automatically closed in 30 days if there isn't any further activity. We therefore assume that the user has lost interest or resolved the problem on their own.

Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

ratijas commented 1 year ago

please don't close it in unresolved state

ratijas commented 1 year ago

Thanks! \o/