search

telegramdesktop / tdesktop

Telegram Desktop messaging app
https://desktop.telegram.org/
Other
26.38k stars 5.24k forks source link

[Feature Request] Add native support for closed-captions in RTMP #24255

Open DearRude opened 2 years ago

DearRude commented 2 years ago

Is your feature request related to a problem?

Adding a subtitle to a video stream (by ffmpeg) requires an effect to be added in each frame, which is resource intensive.

Describe the solution you'd like

By accepting a secondary stream for subtitle, this can be dealt with.

Describe alternatives you've considered

With no support for closed-captions, the video can be hard-subbed beforehand, but the stream looses agility.

Additional context

No response

hamidrezakp commented 2 years ago

Maybe it can be handled by opening client-side subtitles. Or these subtitles can be published by streamer client.

shelbyKiraM commented 2 years ago

On my computer, I just did the default Handbrake Very Fast 720p30 profile from an MKV and in subtitles, changed it from "Foreign Audio Search" to the SSA track, started the encoding, waited a few minutes and, working subs. I played with more settings to keep the same FPS, and it went even faster. Yes, though. Separate .ass or .ssa or .srt subs would be bomb. Maybe a slash command to do both? Or, potentially, something to render mkv in-client, not requiring a save on desktop or a share on iOS (I'm unsure what the playback experience is like on Android, but same).