search

telegramdesktop / tdesktop

Telegram Desktop messaging app
https://desktop.telegram.org/
Other
25.88k stars 5.13k forks source link

A deleted chat still appears in the list #24292

Closed christianmtr closed 1 year ago

christianmtr commented 2 years ago

Steps to reproduce

I made this steps, maybe there is another way to reproduce this.

  1. Login in desktop app (macOS) using QR code.
  2. Select a contact to start a new chat.
  3. Delete that chat for both.
  4. Change account.
  5. Back to new logged in account.
  6. The chat still appears in the list.

Expected behaviour

That the deleted chat is no longer shown in any client.

Actual behaviour

I logged in in another desktop app (windows) and the chat appears there also. i tried to delete many times that chat in both clients but when I go to that account the chat still there. In my phone, that chat is not displayed.

When I start a new chat with that contact in phone, in the desktop apps the chat is displayed but the old conversation is also shown (in my phone is all ok).

Operating system

Windows, MacOS

Version of Telegram Desktop

3.6.1

Installation source

Static binary from official website

Logs

No response

malaguer commented 2 years ago

I have the same problem in Telegram Desktop (v4.0.2, Windos 10 OS) with official Telegram Channel always appearing when I start the program. The channel is always there whenever I restart the program, no matter how many times I remove it. It is quite annoying.

This issue only happens in Desktop version. On the phone everything works fine.

github-actions[bot] commented 1 year ago

Hey there!

This issue was inactive for a long time and will be automatically closed in 30 days if there isn't any further activity. We therefore assume that the user has lost interest or resolved the problem on their own.

Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

plm203 commented 1 year ago

I do have the same issue. I can delete the "resilient" chat in both the web client and the iOS TG app, but on my MacOS high sierra the chat keeps reappearing everytime i launch the app.

Please give us some ideas of things to try and do not close the issue if you have made no attempt to solve the problem.

ntcuong777 commented 1 year ago

As of March 16th, 2023, this bug still exists on the latest stable release. I'm also expecting that the deleted private/group chats are removed on all clients. Additionally, I can still search for the name of the deleted private/group chats.

Currently, I'm using the Telegram Desktop for MacOS downloaded on the official website. The Telegram app for iOS also experiences the same unexpected behavior.

akrotov commented 1 year ago

Same bug for Windows client. Windows 10. Funny that telegram, which claims to be a safe and private messenger ignores such critical security issue for almost a year.

eyad4education commented 1 year ago

Same bug for Windows client. Windows 10. Funny that telegram, which claims to be a safe and private messenger ignores such critical security issue for almost a year.

Not only funny but also annoying

akrotov commented 1 year ago

Same bug for Windows client. Windows 10. Funny that telegram, which claims to be a safe and private messenger ignores such critical security issue for almost a year.

Not only funny but also annoying

Sure. It is actually no funny at all. Only God knows how many were arrested killed and tortured due to this bug in various dangerous places of our world.

kilem02 commented 1 year ago

As of April 6th, 2023, this bug still exists on the latest stable release.I can't delete a chat,FFFFFFFFk!

kilem02 commented 1 year ago

oh bro,i use "switch to Z version" and press F5，then go delete the chat。 Successfully deleted chat. ↑ This method has failed As of May 15th, 2023, this bug still exists on the latest stable release.I can't delete a chat,FFFFFFFFk! I'm sorry for not switching to version check. o(╥﹏╥)o

plm203 commented 1 year ago

Thank you kilem, i already tried that and it didn't work. But i'm going to try an n+1st time.

foxnoodles commented 1 year ago

LOL You guys are a joke of a messenger. This bug is still here. 2 year old chat pops up everytime I link a new device

mass4cr3 commented 1 year ago

The bug is still there and it's really creepy. A few days ago I signed up on Telegram and received an unwanted message from a user. I blocked the user and deleted the message (both for me and for him). This message is still present and undeletable in version A of telegram web. If I'm on the K version, the message is not there... However, if I install the Telegram desktop application on Windows 10 (via the Microsoft Store or desktop.telegram.org), once open the application the message reappears. Maybe it's time to fix this sync problem between Telegram Web A and K, don't you think?

kilem02 commented 1 year ago

Thank you kilem, i already tried that and it didn't work. But i'm going to try an n+1st time.

I am so so so so sorry. o(╥﹏╥)o

alorma commented 1 year ago

A +1 user with the same bug

dearpanan commented 1 year ago

the same bug. windows 11.

akrotov commented 1 year ago

The bug is still there and it's really creepy. A few days ago I signed up on Telegram and received an unwanted message from a user. I blocked the user and deleted the message (both for me and for him). This message is still present and undeletable in version A of telegram web. If I'm on the K version, the message is not there... However, if I install the Telegram desktop application on Windows 10 (via the Microsoft Store or desktop.telegram.org), once open the application the message reappears. Maybe it's time to fix this sync problem between Telegram Web A and K, don't you think?

It means that this is not just a bug of Desktop client, this is a huge security hole. It means that telegram dosen't deletes messages at all (well I was sure that they still keeping them on server), but futhermore - it sends all deleted messages to client applications, and only client application really applied the filtering. That's why the bug is not exists on Android but appears on Mac and Windows PC. Mac and Windows clients has bug in filtering of such messages. But it also means, that alternative 3rd party telegram client is able to show any deleted messages and conversations, including deleted by 3rd parties. Solid security hole of "most secure messager". I can image what is going on in the source code, if poor architecture is seen even without code review, and taking into account that bugs are not fixed for years.

john-preston commented 1 year ago

@akrotov There is no client side filtering, as you can see in the source code.

akrotov commented 1 year ago

How then deleted chat reappears after fresh reinstallation of Telegram, as users reported above (I haven't tried such case)? Something is pushing deleted message to client, there are no other options. Server or client on another side. But if Android app dosen't have this issue (and it dosen't), then it filters such messages. It was just an assumption, but I still don't have another logical explanation of this bug.

john-preston commented 1 year ago

@akrotov The deletion may have a bug, that deletes the messages locally without making a correct delete request to the server. If the app caches the messages in a database, like android, it won't show them even if they're on the server, because it won't request them until you re-login. TDesktop downloads them from server each launch, so it shows what server has. If server received and processed a delete messages request it won't return them anymore, no client side filtering on any apps.

foxnoodles commented 1 year ago

TDesktop downloads them from server each launch, so it shows what server has. If server received and processed a delete messages request it won't return them anymore, no client side filtering on any apps.

I disagree, as the deleted message also appears on iOS client along with Desktop one. I'm a living proof of that. There's a message from a deleted account which I can't delete it comes back each time I relaunch an app both iOS and Desktop. Also even if it is a deletion bug it is still a gaping security/privacy hole. And it is here for years, nobody even bothered to ask any of us to take part in debugging session so that devs could pinpoint the problem. This is actually not surprising as we all know that it is owned by a Russian guy with 1.8 billion net worth who claims that he has nothing to do with Russian government.

john-preston commented 1 year ago

@foxnoodles That means the request may not be handled by the server, but if you see a message after launching TDesktop that means it wasn't deleted on the server (the delete request didn't work), there is still no client side filtering of deleted messages, no such place in source code where server says "here is a message with some text, but it is deleted, so don't show it, please".

If you can this specific message case we can try looking at DebugLogs of TDesktop session with a deletion attempt and see if a request goes to the server, what the server responds and what it sends on the next TDesktop launch. DebugLogs contain all the network data, all requests and responses, so I usually try not asking for them, but in this case I don't have any other ideas.

If you're interested in helping debugging that in this way please contact me at https://t.me/preston, I'll write how to enable the logs, how to collect them and I'll ask you to send them to me.

foxnoodles commented 1 year ago

@john-prestont Aaight lets to this! messaged you

john-preston commented 1 year ago

@foxnoodles OK, one done, there was a server side bug that didn't delete a chat if it has only a single message with id = 1 (first message ever for this user).

Anyone else? @akrotov @dearpanan @alorma @mass4cr3 @plm203 @ntcuong777

plm203 commented 1 year ago

Thank you very much John. This seems to match my case as i had a single message with that correspondent, though i could delete the message. But not the chat, which still opens everytime i open TG. I am still using the latest MacOS desktop version. Will your fix apply in the next release of TG or is it supposed to work already ? Because the problem is still present, unchanged, for my account.

github-actions[bot] commented 1 year ago

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.

plm203 commented 1 year ago

Hi everyone, i've just received the notice of automatic closing. I had left a response, as you can see above, and i don't know why the bot says otherwise. However i have just checked my TG and now the old chat i wanted to delete has finally disappeared, so for me the problem is solved. I guess that is thanks to John, so thank you John.

foxnoodles commented 1 year ago

@plm203 yeah you're welcome. I've provided my personal logs to John in order to fix this. You could've done the same months ago.

plm203 commented 1 year ago

@foxnoodles thank you. I would have done anything i would have been asked. No one asked me my logs; i have no idea where to get them, and had no idea they could be useful.

foxnoodles commented 1 year ago

@foxnoodles thank you. I would have done anything i would have been asked. No one asked me my logs; i have no idea where to get them, and had no idea they could be useful.

The dev literally asked and tagged you and others who complained about the bug in the comment above.