search

telegramdesktop / tdesktop

Telegram Desktop messaging app
https://desktop.telegram.org/
Other
25.88k stars 5.13k forks source link

[Feature Request] Configure message corners #25265

Closed Neurotoxin001 closed 1 year ago

Neurotoxin001 commented 1 year ago

Is your feature request related to a problem?

Yes. I don't want to see too circular message corners: image

Describe the solution you'd like

Make option to configure message corners like it's done on iOS: image image image

Describe alternatives you've considered

No

Additional context

No response

ShadowJonathan commented 1 year ago

The only reason I used tdesktop over the swift version is so I do not have rounded corners, Telegram iOS also has this feature, why was this removed?

https://bugs.telegram.org/c/21787

ShadowJonathan commented 1 year ago

This was added in https://github.com/telegramdesktop/tdesktop/commit/ba2f92906bb273f57c409b4b886fcf74dbd7bb99, it seems, as part of the topics change.

@john-preston people liked this feature, at least provide a slider like in iOS?

natewind commented 1 year ago

Yes please! The old border-radius was perfect, and the current one is garbage.

namikiri commented 1 year ago

I support this issue/request as well.

Although modern™ design guidelines©®™ tell you to make the corners as more round as you can, I still use Windows 10 and it has square windows and UI elements. I'd be happy to have the bubble corner radiuses configurable exactly as in Android app with an option to set it to 0.

hatkidchan commented 1 year ago

Also support that issue. I hate round borders everywhere. Our screens are square, and so should be everything else. If you want round corners — sure, make that toggle-able.

Also, it's not a minor improvement, but a huge downgrade. image

Would also be nice to not just have them "less round", but make them with sharp edges. My entire system has them and having ONE app with them just ruins everything.

mironuk commented 1 year ago

I've just updated Telegram and these too-rounded corners look ugly. I would like to have a setting like in Android Telegram, I would like to set corner radius to 5, for example.

Pablete1234 commented 1 year ago

I've seen the update today and it's clearly a downgrade, side-by-side comparison, left is 4.2.4, right is 4.3.0:

image

If the change is to stay, add a toggle to be able to maintain smaller corners (via either setting, or theme property), like the android app has.

If anyone else is looking into how to remove border-radius for now, you can download 4.2.4 from https://github.com/telegramdesktop/tdesktop/releases/tag/v4.2.4 and disable auto-updating on advanced settings

natewind commented 1 year ago

Yep, on single-line messages it turns into the horrible border-radius: 50% trend.

APT-ZERO commented 1 year ago

damn it, revert it please

Pablete1234 commented 1 year ago

@Neurotoxin001 maybe add reverting to 4.2.4 in "Describe alternatives you've considered"

defterade commented 1 year ago

Telegram Desktop already tried rounded corners in 2016. It wasn't a good idea then and it isn't a good idea now.

ShadowJonathan commented 1 year ago

In that thread, @john-preston said:

A lot of design decisions are just personal preference.

@john-preston While i can understand this statement in 2016, its 2022 now, the platform has millions of users now, this is a repo under the (relatively official) telegramdesktop organisation, and you're making decisions for all those users without first consulting or making it an alternative first.

And like back then, this wasnt a good idea then, and its still not now, make it optional.

john-preston commented 1 year ago

@ShadowJonathan The bubbles redesign is not my preference, but the official design mockups given to me. It was really hard implementing them 😅 So I wouldn't do that if I decided.

ShadowJonathan commented 1 year ago

Okay, that is fair enough, but could you please then provide a way to toggle between hard corners and round corners?

Like i said, one of the reasons i use tdesktop over the swift version is because the swift version has a bubble UI that doesnt look as trimmed as tdesktop is/was.

john-preston commented 1 year ago

@ShadowJonathan It is not planned right now, sorry. I'll ask, if it is required, but really I think this setting in mobile apps wasn't needed and shouldn't be anywhere. But they added it 🤔

DragoonAethis commented 1 year ago

but really I think this setting in mobile apps wasn't needed

Well, at least 60 of us here absolutely do think it's necessary ^^' Would you accept a PR with legacy/round corners toggle in experimental settings?

23rd commented 1 year ago

Like i said, one of the reasons i use tdesktop over the swift version is because the swift version has a bubble UI that doesnt look as trimmed as tdesktop is/was.

Actually the swift version has an option to disable the bubble mode.

john-preston commented 1 year ago

@DragoonAethis Depends on the amount of code added (don't want to make complex logic for the bubbles much more complex), but generally yes, I'll accept it.

APT-ZERO commented 1 year ago

but really I think this setting in mobile apps wasn't needed

Well, at least 60 of us here absolutely do think it's necessary ^^' Would you accept a PR with legacy/round corners toggle in experimental settings?

it's better if this option be in 'Chat Settings' like tg android app option to revert it to classic style or option to set custom radius, both are good options

SpL1Ne commented 1 year ago

@ShadowJonathan It is not planned right now, sorry. I'll ask, if it is required, but really I think this setting in mobile apps wasn't needed and shouldn't be anywhere. But they added it 🤔

Lol, what? So, to get this straight: official android app has this setting, as I understand, official iOS app also has this setting and you won't add it because you think this setting isn't needed and should be removed? Nice.

SuperZombi commented 1 year ago

I agree with what has been said above. Add a setting for rounded corners!

APT-ZERO commented 1 year ago

@ShadowJonathan It is not planned right now, sorry. I'll ask, if it is required, but really I think this setting in mobile apps wasn't needed and shouldn't be anywhere. But they added it 🤔

Lol, what? So, to get this straight: official android app has this setting, as I understand, official iOS app also has this setting and you won't add it because you think this setting isn't needed and should be removed? Nice.

Bro don't make him angry, he can do whatever he wants, thanks him that not infected us with a wiper or ransomware yet

DragoonAethis commented 1 year ago

image

This is all pretty much driven from bubbleRadiusLarge and msgFileThumbRadiusLarge being a little toned down. Probably not perfect around bot keyboards and what not, but should be good enough for very little extra code on an experimental feature.

SpL1Ne commented 1 year ago

@ShadowJonathan It is not planned right now, sorry. I'll ask, if it is required, but really I think this setting in mobile apps wasn't needed and shouldn't be anywhere. But they added it 🤔

Lol, what? So, to get this straight: official android app has this setting, as I understand, official iOS app also has this setting and you won't add it because you think this setting isn't needed and should be removed? Nice.

Bro don't make him angry, he can do whatever he wants, thanks him that not infected us with a wiper or ransomware yet

No, he can't do whatever he wants. This is not his pet-project or something like that. This is OFFICIAL, according to telegram.org, desktop application. And, as far as I can understand, usually every app in one ecosystem of some service has same functionality, features, etc. If he can't maintain application according to ecosystem than he should discuss it with his boss\manager instead of saying basically "I don't like it so I won't do it".

DragoonAethis commented 1 year ago

@john-preston Done, check it out: https://github.com/telegramdesktop/tdesktop/pull/25305

ShadowJonathan commented 1 year ago

Actually the swift version has an option to disable the bubble mode.

Right, but the alternative is a "text" mode against one background, not a square-bubble version.

Aokromes commented 1 year ago

https://github.com/telegramdesktop/tdesktop/commit/9d59e42b522b9403994e5b704a4fe4004003c95d

ShadowJonathan commented 1 year ago

Nice! I assume this just needs an app update, and then all regular users can use this? Or does it need flags/extra configuration to access this?

RememberTheAir commented 1 year ago

@ShadowJonathan it will be a checkbox under settings -> advanced -> experimental settings. Everyone can use it, but it's a bit hidden

APT-ZERO commented 1 year ago

it should not be in experimental settings, it should be in 'Chat Settings' like other tg apps

mpeter50 commented 1 year ago

Why would this have to be in experimental settings? There is nothing experimental in it. This has worked for a long time perfectly fine, and this is also the preferred option for a lot of users. If anything, the option to turn on rounding should be in the experimental settings.

DragoonAethis commented 1 year ago

Why would this have to be in experimental settings? There is nothing experimental in it.

Because there were a lot of changes introduced to support rounding in the first place and many styles were at least subtly modified to fit the new style - disabling rounding toggles just two styles to get back most of the old look, but wasn't comprehensively tested. If everything works fine, it can be moved to chat settings later.

dancojocaru2000 commented 1 year ago

This is a big case of "if it ain't broke, don't fix it".

Stupidly rounded corners seem to be universally disliked by users. @DragoonAethis How were "a lot of changes introduced to support rounding" viewed as a reasonable thing to spend time on when nobody asked for it and a lot of people dislike it?

DragoonAethis commented 1 year ago

@dancojocaru2000 It was not my decision or preference, nor was it the main dev's. The redesign was a "product" decision, so the best thing you can do now is upvote and comment here or let the official support know here to voice your disapproval. All I did was to add a toggle that lets you revert this, starting from the next version.

dancojocaru2000 commented 1 year ago

Since it wasn't obvious to me until I read your reply just now, I apologise if the mention seemed accusatory. I didn't want to put blame on you, and my mention was just because I was quoting you.

Also, thank you for the answer. It is both the best answer I could receive in that it does show me how this was viewed as a reasonable thing to do (namely, because it was an imposed decision), and also because you showed me where I could voice my disapproval.

Thank you as well for adding the toggle. Unlike some of the main devs, I believe that a setting is always better than no setting when no setting means the worst possible option is forced onto everyone, so I appreciate that it was added so quickly.

As others have said, the toggle should be in chat settings to be uniform with the iOS (Appearance serves that page's role there) and Android apps. That being said, a hidden or misplaced setting is still better than no setting, and I do want to end on the positive note of thanking you for the effort.

DragoonAethis commented 1 year ago

No offense taken, no worries. As for the toggle, while I'd like to see it in chat settings as well, getting the rounded corners did require a lot of changes all across the codebase - just look at this diff, and that doesn't even include some later fixes. Switching just 2 styles from underneath all of that appears to mostly work, but I want to make sure the layout doesn't break first. It can be moved later if nothing explodes.