search

telegramdesktop / tdesktop

Telegram Desktop messaging app
https://desktop.telegram.org/
Other
26.23k stars 5.2k forks source link

Thai font broke after upgrade to v4.6.0 #25825

Closed icez closed 1 year ago

icez commented 1 year ago

Steps to reproduce

With reference to issue https://github.com/telegramdesktop/tdesktop/issues/7845 . The situation is about the same. The previous stable version on Windows OS seems to use Tahoma for displaying Thai language but on v4.6.0 it seems to change to another font which cause Thai word to be too small compare to other.

v4.6.0 https://imgur.com/rvIdiAF

v4.5.3 https://imgur.com/o27t0T9

Expected behaviour

v4.5.3 https://imgur.com/o27t0T9

Actual behaviour

v4.6.0 https://imgur.com/rvIdiAF

Operating system

Windows 11

Version of Telegram Desktop

v4.6.0

Installation source

Static binary from official website

Logs

No response

ilya-fedin commented 1 year ago

not if you have several languages on computer and russian is not main display language.

You want to say tdesktop doesn't use Open Sans for Russian on your computer? If it doesn't, can you provide log.txt from %APPDATA%\Telegram Desktop?

tarkungZZ commented 1 year ago

After update this issue happen to me as well.

7Vlad commented 1 year ago

You want to say tdesktop doesn't use Open Sans for Russian on your computer? If it doesn't, can you provide log.txt from %APPDATA%\Telegram Desktop?

[2023.02.07 11:34:22] Font: from ':/gui/fonts/DAOpenSansRegular.ttf' loaded 'DAOpenSansRegular' [2023.02.07 11:34:22] Font: from ':/gui/fonts/DAVazirRegular.ttf' loaded 'DAVazirRegular' [2023.02.07 11:34:22] Font: from ':/gui/fonts/DAOpenSansRegularItalic.ttf' loaded 'DAOpenSansRegularItalic' [2023.02.07 11:34:22] Font: from ':/gui/fonts/DAVazirRegular.ttf' loaded 'DAVazirRegular' [2023.02.07 11:34:22] Font: from ':/gui/fonts/DAOpenSansSemiboldAsBold.ttf' loaded 'DAOpenSansSemibold' [2023.02.07 11:34:22] Font: from ':/gui/fonts/DAVazirMediumAsBold.ttf' loaded 'DAVazirMedium' [2023.02.07 11:34:22] Font: from ':/gui/fonts/DAOpenSansSemiboldItalicAsBold.ttf' loaded 'DAOpenSansSemiboldItalic' [2023.02.07 11:34:22] Font: from ':/gui/fonts/DAVazirMediumAsBold.ttf' loaded 'DAVazirMedium' [2023.02.07 11:34:22] Font: from ':/gui/fonts/DAOpenSansSemiboldAsBold.ttf' loaded 'DAOpenSansSemibold' [2023.02.07 11:34:22] Font: from ':/gui/fonts/DAVazirMediumAsBold.ttf' loaded 'DAVazirMedium' [2023.02.07 11:34:22] Font: from ':/gui/fonts/DAOpenSansSemiboldItalicAsBold.ttf' loaded 'DAOpenSansSemiboldItalic' [2023.02.07 11:34:22] Font: from ':/gui/fonts/DAVazirMediumAsBold.ttf' loaded 'DAVazirMedium'

ilya-fedin commented 1 year ago

Can you provide the full log?

7Vlad commented 1 year ago

Can you provide the full log?

I don't want to filter my "private" parts, but if you tell exactly what are you need, I can provide it

Ai-Himmel commented 1 year ago

The same issue for text in Chinese on the Simplified Chinese system. Font for Chinese became SimSun. A workaround provided by community is here Save as something.reg file and run. Users in other language can changed the alias font as you like. IT WOULD WRITE SOMETHING TO YOUR REGITRY, USE AT YOUR OWN RISK 

Windows Registry Editor Version 5.00

[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows NT\CurrentVersion\FontSubstitutes]
"DAOpenSans"="Microsoft YaHei UI"
"DAOpenSansBold"="Microsoft YaHei UI Bold"
"DAOpenSansBoldItalic"="Microsoft YaHei"
"DAOpenSansRegular"="Microsoft YaHei"
"DAOpenSansRegularItalic"="Microsoft YaHei"
"DAOpenSansSemibold"="Microsoft YaHei"
"DAOpenSansSemiboldItalic"="Microsoft YaHei"
"DAVazir"="Microsoft YaHei"
"DAVazirBold"="Microsoft YaHei Bold"
"DAVazirMedium"="Microsoft YaHei Light"
"DAVazirRegular"="Microsoft YaHei"
;; Priority font resolving: "Cascadia Mono", "Consolas", "Liberation Mono", "Menlo", "Courier"
;; Override monospace font:
"Cascadia Mono"="Consolas"
ilya-fedin commented 1 year ago

@7Vlad the log.txt has no private parts

biaocy commented 1 year ago

The same issue for text in Chinese on the Simplified Chinese system. Font for Chinese became SimSun. A workaround provided by community is here Save as something.reg file and run. Users in other language can changed the alias font as you like. IT WOULD WRITE SOMETHING TO YOUR REGITRY, USE AT YOUR OWN RISK

Windows Registry Editor Version 5.00

[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows NT\CurrentVersion\FontSubstitutes]
"DAOpenSans"="Microsoft YaHei UI"
"DAOpenSansBold"="Microsoft YaHei UI Bold"
"DAOpenSansBoldItalic"="Microsoft YaHei"
"DAOpenSansRegular"="Microsoft YaHei"
"DAOpenSansRegularItalic"="Microsoft YaHei"
"DAOpenSansSemibold"="Microsoft YaHei"
"DAOpenSansSemiboldItalic"="Microsoft YaHei"
"DAVazir"="Microsoft YaHei"
"DAVazirBold"="Microsoft YaHei Bold"
"DAVazirMedium"="Microsoft YaHei Light"
"DAVazirRegular"="Microsoft YaHei"
;; Priority font resolving: "Cascadia Mono", "Consolas", "Liberation Mono", "Menlo", "Courier"
;; Override monospace font:
"Cascadia Mono"="Consolas"

Fix Chinese font issue

CurtisWong458 commented 1 year ago

Has the latest version 4.6.2 fixed this BUG?

boypt commented 1 year ago 
DAOpenSans

People ask if this reg file affects the system fonts. yes and no.

Yes, because the patch is applied to the Windows font replacement mechanism. But this patch is meant to replace those fonts that start with "DA", e.g. "DAOpenSans".

So the patch only affects Telegram for those fonts starting with "DA" are ALL of Telegram custom font, no other programs will be affected.

7Vlad commented 1 year ago

@7Vlad the log.txt has no private parts

Of course, it has. Like full path to Telegram directory, full path to taskbar and ALL list of your applications pinned to taskbar, etc. So, what exactly you need from my log?

ilya-fedin commented 1 year ago

I believe it should contain more lines about fonts starting with "Fonts Info:" and "Font Error:" if the font failed to load

7Vlad commented 1 year ago

I believe it should contain more lines about fonts starting with "Fonts Info:" and "Font Error:" if the font failed to load

This is what I assumed and therefore all the lines with the word "font"/fonts, I copied above

itayganor commented 1 year ago

Version 4.6.2 seems to fix the issue for Hebrew.

likecyber commented 1 year ago

Version 4.6.2 seems to fix the issue of Thai language for me as well.

Anyone who installs my quick fix can remove the fonts and update the Telegram Desktop app to 4.6.2 now.

Artur2048 commented 1 year ago

Yes. 4.6.2 seems to fix it for me as well (Thai font).

On Thu, Feb 9, 2023 at 7:14 AM Likecyber @.***> wrote:

Version 4.6.2 seems to fix the issue of Thai language for me as well.

Anyone who installs my quick fix can remove the fonts and update the Telegram Desktop app to 4.6.2 now.

— Reply to this email directly, view it on GitHub https://github.com/telegramdesktop/tdesktop/issues/25825#issuecomment-1423406658, or unsubscribe https://github.com/notifications/unsubscribe-auth/APCCWGHB2IYCILE7QDUKDL3WWQZFJANCNFSM6AAAAAAUQ7TR2Q . You are receiving this because you commented.Message ID: @.***>

BlackMercy commented 1 year ago

I have been waiting for the fix so I stayed at 4.5.3 without updating to 4.6.0 when it was released. Now many people are confirming that 4.6.2 fixed the issue so I updated Telegram Desktop on my PC. I can also confirm that Thai font looks exactly the same as in 4.5.3.

Thanks dev team for fixing this quickly!

iBug commented 1 year ago

I can confirm that the "workaround for Chinese fonts on English systems" is also working again, the same way as it used to in v4.5.3.

nolykhemin commented 1 year ago

Yes guys v4.6.2 seems to fix Thai font fallback problem for me (win 11) This issue can be closed now

7Vlad commented 1 year ago

I am still have a problem with fonts in 4.6.2. Also in "Settings", Interface Scale now have maximum only 100% and in 4.5.3 it was 300%. So maybe problem with fonts is "fixed", but what's going on with scale? Screenshot_46 Screenshot_47

ilya-fedin commented 1 year ago

Can you provide the screenshot of broken font? For scaling issue provide logs in #25856

7Vlad commented 1 year ago

Can you provide the screenshot of broken font?

As you can see on my screenshots (and this is not actual size, because github enlarge the image), first image(4.6.2) fonts is smaller than second(4.5.3). The size was the same on 4.6-4.6.1, but scale was "300%", now, in 4.6.2, it was "fixed", so its show 100% instead of 300%. The key for shortcut "-scale 125" didn't work at all.

ilya-fedin commented 1 year ago

This doesn't seem to be related to fonts and this issue, it's interface scale

7Vlad commented 1 year ago

This doesn't seem to be related to fonts and this issue, it's interface scale

So fonts issue was "fixed" with replacing maximum interface scale from 300% to 100%? But, for me, as for user, nothing was changed, because interface/font still smaller than it was on 4.5.3., as you can see on my actual screenshots. It doesn't matter for me, how you called this issue, I am only want my font size/interface scale back.

ilya-fedin commented 1 year ago

@7Vlad no, you have a completely another issue, please discuss it in the respective ticket

7Vlad commented 1 year ago

@7Vlad no, you have a completely another issue, please discuss it in the respective ticket

here https://github.com/telegramdesktop/tdesktop/issues/25856 ?

ilya-fedin commented 1 year ago

yes