Closed mr05je closed 10 months ago
I discovered that vpx library name is changed to vpxmt.lib, not vpx.lib🤔 That's why ffmpeg can't find vpx decoder.
https://github.com/desktop-app/patches/blob/master/libvpx/0003-generate-vpx-pc-with-msvs.patch#L38
Should i wait or i can change it myself?
Should i wait or i can change it myself?
If you want to run successfully...
First, change that patch L38 -lvpx
> -lvpxmt
and recompile libvpx and ffmpeg.
After that, compile TDesktop.
Everything should be fine.
After changing patch, app builds, runs for 5 secs now and crashing with same error. FFmpeg builds with same warnings
LINK : warning LNK4044: unrecognized option '/IY/Telegram/TelegramDesktop/Libraries/win64/patches/../local/include'; ignored
But main error LINK : fatal error LNK1181: cannot open input file 'vpx.lib'
disappeared
After changing patch, app builds, runs for 5 secs now and crashing with same error. FFmpeg builds with same warnings
LINK : warning LNK4044: unrecognized option '/IY/Telegram/TelegramDesktop/Libraries/win64/patches/../local/include'; ignored
But main error
LINK : fatal error LNK1181: cannot open input file 'vpx.lib'
disappeared
Is it still crash for FindDecoder
?
Anyway, you can ignore this warning, this did not affect something.
Yes P.S.: rebuilt from scratch
so strange...
I'm fine after change to -lvpxmt
.
strange, but after the rebuild everything works fine now, ty
I see it handles when codec returns nullptr, shouldn't it run just fine just be unable to play vp9 media?
because of animated emojis
I see it handles when codec returns nullptr, shouldn't it run just fine just be unable to play vp9 media?
nullptr would lead to crash after this step. Cause it would declare a null codec and custom emoji/video sticker render can't use it. https://github.com/telegramdesktop/tdesktop/blob/dev/Telegram/SourceFiles/ffmpeg/ffmpeg_frame_generator.cpp#L106 https://github.com/telegramdesktop/tdesktop/blob/dev/Telegram/SourceFiles/ffmpeg/ffmpeg_frame_generator.cpp#L313
Indeed...
Thanks for the report!
Steps to reproduce
Expected behaviour
App should start and work correctly
Actual behaviour
App launch for ~1 sec, but after that app crashing by ffmpeg
Additional info:
Also, I opened ffmpeg's config.log, and there was linking error with libvpx:
Operating system
Windows
Version of Telegram Desktop
4.10.1
Installation source
Other (unofficial) source
Crash ID
No response
Logs