search

telegramdesktop / tdesktop

Telegram Desktop messaging app
https://desktop.telegram.org/
Other
26.23k stars 5.2k forks source link

Version 4.16.9 broke app UI (font aspect) #27804

Closed tomkoi closed 6 months ago

tomkoi commented 6 months ago

Steps to reproduce

Upgrade to late test playing with font and scale options revert to older version

Expected behaviour

I really like how the app was until today, not sure what the font it's using, but by mistake I got the 4.16.9 and with new font option change + interface scale all the UI looks bad, and I can't read anything as I used to, I tried to play with the fonts and the scale - nothing helped. After revert to 4.16.8 all good. Sadly I don't have a screenshot, but I'm Mac m1 user with Dell 4k 27' monitor.

Actual behaviour

I really like how the app was until today, not sure what the font it's using, but by mistake I got the 4.16.9 and with new font option change + interface scale all the UI looks bad, and I can't read anything as I used to, I tried to play with the fonts and the scale - nothing helped. After revert to 4.16.8 all good. Sadly I don't have a screenshot, but I'm Mac m1 user with Dell 4k 27' monitor.

Operating system

MacOS

Version of Telegram Desktop

4.16.9

Installation source

Static binary from official website

Crash ID

No response

Logs

No response

ilya-fedin commented 6 months ago

Please upload a screenshot with default settings. There were no change to the default font so it's unclear what happens to you.

tomkoi commented 6 months ago

Please upload a screenshot with default settings. There were no change to the default font so it's unclear what happens to you.

Wish I could explain more from it, but this is the best. I little bit afraid to update again

ilya-fedin commented 6 months ago

The problem is the report is use-less as-is and nothing could be done on it. On developer's machines, the text looks the same as on previous version.

Aokromes commented 6 months ago

https://i.imgur.com/f2BX9Qr.png 4.16.8 on left, 4.16.9 on right, i see both the same. (windows 10)

edit: bug looks to be hebrew font only.

TomCo2210 commented 6 months ago

Same here, Hebrew fonts are broken and it looks really bad! 4.16.9 beta on Win11 image on the right 4.16.9, on the left 4.16.8

ilya-fedin commented 6 months ago

Please, when you do such reports, upload screenshots of how it was, how it is, how it should be and provide an example of the text to copy. Otherwise it's not actionable.

TomCo2210 commented 6 months ago

edited my message with a picture added as example.

ilya-fedin commented 6 months ago

@TomCo2210 it looks just not that thick? Is this really a problem?

Please provide the log.txt file from the data directory and the value of Chat settings -> Font family option.

tomkoi commented 6 months ago

https://i.imgur.com/f2BX9Qr.png 4.16.8 on left, 4.16.9 on right, i see both the same. (windows 10)

Strange, so it’s can be releated to macOS and Hebrew chats (I from IL)

tomkoi commented 6 months ago

Same here, Hebrew fonts are broken and it looks really bad! 4.16.9 beta on Win11 image on the right 4.16.9, on the left 4.16.8

thanks Tom :) this exactly what i saw too

Aokromes commented 6 months ago

i.imgur.com/f2BX9Qr.png 4.16.8 on left, 4.16.9 on right, i see both the same. (windows 10)

Strange, so it’s can be releated to macOS and Hebrew chats (I from IL)

i.imgur.com/f2BX9Qr.png 4.16.8 on left, 4.16.9 on right, i see both the same. (windows 10)

Strange, so it’s can be releated to macOS and Hebrew chats (I from IL)

no, windows have same bug with hebrew texts.

TomCo2210 commented 6 months ago

@TomCo2210 it looks just not that thick? Is this really a problem?

Yes, It is a problem!

Please provide the log.txt file from the data directory and the value of Chat settings -> Font family option.

log.txt font family set on Default, on the 4.16.9, no such option on the 4.16.8.

ilya-fedin commented 6 months ago

I wonder whether that's a real bug or folks just don't like the new look personally while it's actually ok. Hard to say without logs and a text example.

ilya-fedin commented 6 months ago

I checked the old and the new version of Open Sans font: the old one doesn't have support for Hebrew text while the new one does. This means, while you may not like it, this seems like an intended change done by the Open Sans font developers and since tdeksktop uses this font, you have three options:

  1. Get used to that
  2. Complain to https://github.com/googlefonts/opensans so they improve the Hebrew part. When they will do that, feel free to open an issue at tdesktop repo and I will update the font (or you folks can create a PR directly at https://github.com/desktop-app/lib_ui updating the ttf files)
  3. Use the new option to set the font you like
Aokromes commented 6 months ago

https://imgur.com/5kfcf9y this ussing "system font" on .9

ilya-fedin commented 6 months ago

As of now, this doesn't look like a valid bug. Just people don't like changes.

tomkoi commented 6 months ago

I checked the old and the new version of Open Sans font: the old one doesn't have support for Hebrew text while the new one does. This means, while you may not like it, this seems like an intended change done by the Open Sans font developers and since tdeksktop uses this font, you have three options:

  1. Get used to that
  2. Complain to https://github.com/googlefonts/opensans so they improve the Hebrew part. When they will do that, feel free to open an issue at tdesktop repo and I will update the font (or you folks can create a PR directly at https://github.com/desktop-app/lib_ui updating the ttf files)
  3. Use the new option to set the font you like

ok, i've open bug for dev font team: https://github.com/googlefonts/opensans/issues/87 and used @TomCo2210 picture, @ilya-fedin can you please provide the old ttf file that the app used before the font change or i need to download from the font repo? then it's possible to put it's in telegram config manually? (on my comp)

ilya-fedin commented 6 months ago

ok, i've open bug for dev font team:

I'm doubt they will treat it as a valid report. You need to tell them what you find broken in the hebrew glyphs and how they could improve it.

can you please provide the old ttf file that the app used before the font change or i need to download from the font repo?

Those ttfs won't be useful because they were patched for the font choosing logic which is no longer in place. Although, maybe going through open sans repo you will find an unpatched version of the good one?

tomkoi commented 6 months ago

ok, i've open bug for dev font team:

I'm doubt they will treat it as a valid report. You need to tell them what you find broken in the hebrew glyphs and how they could improve it.

i not sure really how to explain the problem beside to see that there is really different

can you please provide the old ttf file that the app used before the font change or i need to download from the font repo?

Those ttfs won't be useful because they were patched for the font choosing logic which is no longer in place. Although, maybe going through open sans repo you will find an unpatched version of the good one?

So how in version 4.16.8 it's still good? The app don't have some config folders/files to change manually if I want too?

ilya-fedin commented 6 months ago

So how in version 4.16.8 it's still good?

Because it's old version which has that logic and those old patched fonts, no?

m-sergiy26 commented 6 months ago

https://i.imgur.com/f2BX9Qr.png 4.16.8 on left, 4.16.9 on right, i see both the same. (windows 10)

Offtop. How to change the left side menu of folders to white?

ilya-fedin commented 6 months ago

Regarding macOS, I believe setting to "System font" should provide you a good result. As falling back to system Hebrew font is what was happening previously.

For Windows, that might be not the best choice now as Qt uses legacy API which uses outdated fonts for latin but should still return the old font for Hebrew. If https://github.com/desktop-app/patches/pull/193 would get in and through beta testing, system font on Windows would likely be good for latin, too, as it will be Segoe UI.

ilya-fedin commented 6 months ago

How to change the left side menu of folders to white?

With a custom theme. I don't know what the theme keys for it are but people in https://t.me/TelegramDesktopTalk likely know.

m-sergiy26 commented 6 months ago

How to change the left side menu of folders to white?

With a custom theme. I don't know what the theme keys for it are but people in https://t.me/TelegramDesktopTalk likely know.

thanks!

ilya-fedin commented 6 months ago

As far as I can see, the old version of Open Sans was 1.10 while the current version is 3.003.

tomkoi commented 6 months ago

So how in version 4.16.8 it's still good?

Because it's old version which has that logic and those old patched fonts, no?

i really new in all this so i assume you right :)

As far as I can see, the old version of Open Sans was 1.10 while the current version is 3.003.

so there is no way to import manually the old tff file?

Regarding macOS, I believe setting to "System font" should provide you a good result. As falling back to system Hebrew font is what was happening previously.

i tried also with system default font, still something not looks right or good as it's in 4.16.8

ilya-fedin commented 6 months ago

so there is no way to import manually the old tff file?

I see lots of results in google when I search for "open sans 1.10" so you can download it, install by your system means and... perhaps get nothing because the embedded Open Sans will override the system installed one even if you choose Open Sans explicitly in settings.

tomkoi commented 6 months ago

so there is no way to import manually the old tff file?

I see lots of results in google when I search for "open sans 1.10" so you can download it, install by your system means and... perhaps get nothing because the embedded Open Sans will override the system installed one even if you choose Open Sans explicitly in settings.

it's bad :( but thank you for the trying at least :) hope someday i will fixed somehow

ilya-fedin commented 6 months ago

i tried also with system default font, still something not looks right or good as it's in 4.16.8

If you were more specific, like uploading screenshots and marking what you don't like, maybe it would be possible to find what is not right.

tomkoi commented 6 months ago

i tried also with system default font, still something not looks right or good as it's in 4.16.8

If you were more specific, like uploading screenshots and marking what you don't like, maybe it would be possible to find what is not right.

you right, anyway 4.16.9 still beta so for now if it's working fine i not touch it

nik1t0zz commented 6 months ago

The old version of https://github.com/desktop-app/lib_ui uses "DAOpenSansRegular 1.10" instead of "Open Sans 3.003" that is used in the beta, so just switching out to the old fonts only partially fixes the issue.

Switching the font in TG settings to DAOpenSansRegular will not change the bold font to DAOpenSansSemiBold (or Bold), but will instead change it to some other default bold font, causing a jarring difference.

The new font is incredibly bad when it comes to Hebrew, as other people have pointed out, and my friend says so too, but it also changed the look of the "б" cyrillic B character, that now stands out it a horrible way.

I've sent "feedback" on Google Fonts, but I doubt they will change this character or improve Hebrew (it's been like 4 years now since those changes on their github).

There seems to be two ways of fixing this:

  1. Switching back to previous OpenSans version (1.10);
  2. Or fixing the behavior that picks Bold, Italics etc versions of fonts, so you could at least revert it correctly (and maybe shipping the old fonts too, so users won't need to download them).
ilya-fedin commented 6 months ago

Switching the font in TG settings to DAOpenSansRegular will not change the bold font to DAOpenSansSemiBold (or Bold), but will instead change it to some other default bold font, causing a jarring difference.

That's what I meant by the old code made specially for those patched fonts being no more in place. You have to find unpatched Open Sans of version 1.10 in the Internet. It will be shadowed by the embedded Open Sans likely, though.

nik1t0zz commented 6 months ago

You have to find unpatched Open Sans of version 1.10 in the Internet.

I can find them in the repo I linked to, specifically at the time of this commit.

It will be shadowed by the embedded Open Sans likely, though.

It kind of does, but does not - Regular (as in not bold and not italics) version gets switched correctly to the old version that you choose in the settings, but the bold variant gets taken from some other font, ignoring the DAOpenSansSemibold (that is present in the settings menu, but gets ignored for Bold font choice).

ilya-fedin commented 6 months ago

I can find them in the repo I linked to, specifically at the time of this commit.

No, I said unpatched. These font files are patched. They won't work properly without special logic.

john-preston commented 6 months ago

@ilya-fedin I hope I'll be able to revert OpenSans to 1.10, it should fix the Hebrew characters back to the previous version.

tomkoi commented 6 months ago

@ilya-fedin I hope I'll be able to revert OpenSans to 1.10, it should fix the Hebrew characters back to the previous version.

@john-preston if you will be able to fix it will be awesome :)