telegramdesktop / tdesktop

Telegram Desktop messaging app
https://desktop.telegram.org/
Other
26.13k stars 5.18k forks source link

Using OSM instead of Google Maps #2787

Closed Robot8A closed 4 years ago

Robot8A commented 7 years ago

Hi, I'm wondering why do you use Google Maps when you send/recieve a location. It would be great if you could use OpenStreetMap (it's open source!) instead of GMaps, or if not, let you choose the map provider that you prefer. Thanks.

garro95 commented 6 years ago

I think that at least, the program should let the user choose the map provider from settings.

p0358 commented 5 years ago

Currently it still links to Google Maps, but the preview is definitely not Google Maps, it looks like OSM actually

gorn commented 5 years ago

Make it settable in setting or use geo link

mxa commented 5 years ago

FWIW the competitors have made the switch https://threema.ch/en/blog/posts/threema-android-fresh-look-and-even-more-privacy

gorn commented 5 years ago

Threema makes a good point. By using googlemaps in your application you make user share his position with google without him/her necessarilly knowing it

Skippern commented 5 years ago

With OSM maps, the app could either use any of the already existing tiles services, or host its own.

camelCaseNick commented 5 years ago

@p0358 I searched for it in the source code, but couldn't find it. I hope it's not OSM, because that would be a copyright infringement, because no attribution is added.

Does anyone know the source of the current map image?

I'd prefer at least the option to opt for another map provider, since Google is still the one linked from the image, though the image doesn't look to originate from Google.

p0358 commented 5 years ago

@camelCaseNick Honestly I cannot confirm that for sure at all, I am aware of some detail differences between Google, OSM and Bing, but they're impossible to tell apart near my location at these zoom levels. Would need to search for some public examples where there's huge difference in mapping details between Google and OSM and check these ones to judge. And I think the map preview might be generated purely by the server, so there are big chances you won't find it in the code thus.

mxa commented 5 years ago

The preview image is definitely OSM and there doesn't seem to be attribution. Anyway this is a different issue then this one, @camelCaseNick if you feel strongly about this, open another issue and demand attribution, this issue is about replacing Google or at least to give the user the choice.

Aokromes commented 5 years ago

if generation is generated server side, i think there is no need of attribution.

camelCaseNick commented 5 years ago

@Aokromes No, it has nothing to do with the images. Yes, the images from many OSM tiles are under a CC-BY-SA or alike, but the data itself is already under the ODbL (with an attribution requirement). So "© OpenStreetMap contributors" is still needed. But @mxa is right, this issue is about to use OSM and not to use it right. (Though both go hand in hand.)

Aokromes commented 4 years ago

generic ticket. https://github.com/telegramdesktop/tdesktop/issues/6789

github-actions[bot] commented 3 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.