search

telegramdesktop / tdesktop

Telegram Desktop messaging app
https://desktop.telegram.org/
Other
26.23k stars 5.21k forks source link

Add shortcut for rotate video #28053

Closed zjplab closed 4 months ago

zjplab commented 4 months ago

Is your feature request related to a problem?

In the media player window, we have play, pause, zoom(alt+enter) and rotate, among with many other functions. But for commonly used rotate function, there is no short associated with.

Describe the solution you'd like

Adding shortcut for rotating will be nice. Or better, develop a mapping config that can let you control which key maps to which function/button.

Describe alternatives you've considered

na

Additional context

No response

ilya-fedin commented 4 months ago

Or better, develop a mapping config that can let you control which key maps to which function/button.

it already exists in tdata directory

Aokromes commented 4 months ago

i think he means with a GUI xd

zjplab commented 4 months ago

@ilya-fedin @Aokromes I mean guess the rotate screen is using playbackControlsRotate() function? And there is very limited command registered in https://github.com/telegramdesktop/tdesktop/blob/4047f1733decd5edf96d125589f128758b68d922/Telegram/SourceFiles/core/shortcuts.cpp#L395. It's hardcoded in the code also, not being able to let users decide the keymap.

ilya-fedin commented 4 months ago

@zjplab it's not hardcoded, there's a json file tdata as I already said. You see the, function is called "fillDefaults".