telegramdesktop / tdesktop

Telegram Desktop messaging app
https://desktop.telegram.org/
Other
25.29k stars 5.03k forks source link

Better night mode #3835

Closed stek29 closed 5 years ago

stek29 commented 6 years ago

From this comment

It would be nice to use "night mode" as a way to have two different themes installed.

Suggested behaviour & Steps to reproduce

So night mode would be independent theme "profile" with different default theme, completely independent from light mode.

john-preston commented 6 years ago

@stek29 Yes, I thought about that. This is a serious task.

tyl3r commented 6 years ago

You guys can make it simple, just let the user choice for both default themes (normal and night mode) in a easy way, it would be nice to add 2 additional text buttons or 2 images (⚪️/⚫️ or 🌞 / 🌚) when you preview a theme, the buttons act for set as default: default theme / night mode theme, then in preferences just rewrite the options, remove the actual "user default color theme" for something like "default theme: X (Restore to default)" and "night mode theme: Y (Restore to default)", then the night mode switch just change between the 2 defined themes. Hope you like the idea.

andreyorst commented 6 years ago

I wonder if there is an ability to make both light and dark variant in a single theme. Something like in GNOME for example. In GNOME 3 there are two css files, named gtk.css and gtk-dark.css. User can enable or disable dark theme variant in settings by toggling the switch. Some applications, that support dark mode use gtk-dark.css by default and fallback to gtk.css if there is none.

If telegram will support such thing, there will be no need to set two different themes, a switch will remain in settings if user theme supports nightmode. Or telegram could switch to default night mode theme if user theme don't specify it's own night color scheme.

Yes, this reuires theme creators to add dark mode in their themes, but I think that if a single person designs a theme, night mode should share same style, only adapted to be dark. At least it is a common practice in gtk theming world.

IgorKrupenja commented 5 years ago

Was this closed because this feature is implemented in the upcoming release?

On Aug 3 2018, at 8:14 am, Viktor Oreshkin notifications@github.com wrote:

Closed #3835 (https://github.com/telegramdesktop/tdesktop/issues/3835). — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub (https://github.com/telegramdesktop/tdesktop/issues/3835#event-1769169678), or mute the thread (https://github.com/notifications/unsubscribe-auth/AZIkG7236EEgkNydeDRQEhb8KWnZ1Ak8ks5uM9w6gaJpZM4PC4RT).

Johnnynator commented 5 years ago

It should already be in the alpha release

IgorKrupenja commented 5 years ago

@Johnnynator Great, thanks!

github-actions[bot] commented 3 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.