search

telegramdesktop / tdesktop

Telegram Desktop messaging app
https://desktop.telegram.org/
Other
25.84k stars 5.11k forks source link

Add option to Upload mp4 file with sound as gif #4283

Open LeonnardoVerol opened 6 years ago

LeonnardoVerol commented 6 years ago

Steps to reproduce

  1. Upload a mp4 file

Expected behaviour

It used to convert any mp4 file to gif, since the "instante video on chat" update, that no longer works

Actual behaviour

The mp4 file is always send as a video

stek29 commented 6 years ago

How big is the file?

LeonnardoVerol commented 6 years ago

the mp4 file is 681kb. And i wanna save it as a gif

stek29 commented 6 years ago

It doesn't have sound, does it?

LeonnardoVerol commented 6 years ago

It does but thats not the original sound. Nonetheless, would be useful/helpful to Add an option to Upload any mp4 file as gif (or as a short video). Just like we already have an option to upload a img as img or file

PS: I changed the title to be more accurate

stale[bot] commented 3 years ago

Hey there!

This issue will be automatically closed in 7 days if there would be no activity. We therefore assume that the user has lost interest or resolved the problem on their own.

Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

LeonnardoVerol commented 3 years ago

I still would like to see this feature/enhancement.

Having the option to upload a video as gif or as "original video"

Uploading imgs have something like that

image

ilya-fedin commented 3 years ago

Oh, that would require a lot of code for encoding and adding a lot of libraries to the build process (currently only ffmpeg is built only with built-in codec implementations that support only decoding)

stale[bot] commented 3 years ago

Hey there!

This issue was inactive for a long time and will be automatically closed in 30 days if there isn't any further activity. We therefore assume that the user has lost interest or resolved the problem on their own.

Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

reallyuniquename commented 3 years ago

@ilya-fedin

that would require a lot of code for encoding and adding a lot of libraries to the build process

Can't you just strip audio from mp4 with what you have right now? No encoding, just stream remuxing.

ilya-fedin commented 3 years ago

If you think it's simple then I guess you can write a PoC.

reallyuniquename commented 3 years ago

I don't know how simple that is, that's why I asked a question. But with standalone ffmpeg it does look straightforward.