search

telegramdesktop / tdesktop

Telegram Desktop messaging app
https://desktop.telegram.org/
Other
26.45k stars 5.26k forks source link

[Question] what's involved in building Telegram from source on linux... #6625

Closed lemmy04 closed 4 years ago

lemmy04 commented 5 years ago

...when I want to use as much as possible of the libraries provided by my linux distribution?

Johnnynator commented 5 years ago

Having fun patching the build system and some of the source code, official supported is only what is mentioned in the cmake guide which statically links quite a lot libraries.

lemmy04 commented 5 years ago

ouch. sounds like fun. would you like pull requests if i get to a point where the client actually builds using system libs on more than one linux distribution?

Aokromes commented 5 years ago

preston is who must answer that :P but i am sure if you make PR allowing to choose system libs or old style i am sure he will allow that.

john-preston commented 5 years ago

@lemmy04 You can push a separate building instruction file with that, current one is the one that is used for the official builds.

Also you can start by looking on patches for flathub build or downstream package maintainer builds that already build tdesktop with system libraries.

xvitaly commented 5 years ago

...when I want to use as much as possible of the libraries provided by my linux distribution?

Look at this.

beholders-eye commented 5 years ago

this only works for a RPM based distro and it seems to remove features, I mean, it disables a lot of what makes Telegram great.

xvitaly commented 5 years ago

this only works for a RPM based distro

Yes, because I'm Fedora maintainer. If you want to adopt it to another distribution, you need to replace rpm --eval calls by setting correct paths to installed libraries and headers.

I mean, it disables a lot of what makes Telegram great.

Our patch disable only three features:

  1. updater, because GNU/Linux distributions use package manager and repositories to deliver updates to end users;
  2. crash reporter, because on Fedora we use internal crash reporter - abrt;
  3. generating of shortcuts and mime-handlers, because we already has them in package.
beholders-eye commented 5 years ago

I thought, by roughly reading the patch, that it also removed rlottie and other things. If not, then I apologize for my rash question, it is actually a great help!

xvitaly commented 5 years ago

I thought, by roughly reading the patch, that it also removed rlottie and other things

We removed all bundled libraries to use packaged versions from Fedora repositories.

ilya-fedin commented 4 years ago

DESKTOP_APP_USE_PACKAGED=ON

github-actions[bot] commented 3 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.