search

telegramdesktop / tdesktop

Telegram Desktop messaging app
https://desktop.telegram.org/
Other
25.29k stars 5.03k forks source link

Window titlebar does not follow GTK theme with Qt's Wayland backend #6730

Closed Newbytee closed 4 years ago

Newbytee commented 4 years ago
### Steps to reproduce 1. Run Telegram Desktop with the Qt Wayland backend 2. Observe a titlebar which does not follow the GTK choosen theme ### Expected behaviour Telegram's titlebar should follow my GTK theme as it does with Qt's X11 backend. ![image_2019-10-30_22-23-34](https://user-images.githubusercontent.com/4428753/67900114-058def00-fb64-11e9-8134-e741df4580cc.png) ### Actual behaviour Telegram's titlebar is unthemed and does not follow my GTK theme when using Qt's Wayland backend. This is especially noticeable when using dark GTK themes. ![Screenshot from 2019-10-30 22-21-58](https://user-images.githubusercontent.com/4428753/67900046-d7a8aa80-fb63-11e9-9f52-b61fe65ecf0c.png) (don't mind the variance in window size and buttons, that's because these screenshots are from two different PCs) ### Configuration **Operating system:** Fedora 31 Workstation **Version of Telegram Desktop:** 1.8.15 **Used theme**: Default Night Mode, no Qt theme
scsmash3r commented 4 years ago

Same issue observed in Win 8.1 with Windows 7 compatibility mode: image

Version of Telegram Desktop: 1.8.15

Used theme: Digital Night @themes

Aokromes commented 4 years ago

https://github.com/telegramdesktop/tdesktop/issues/5714

Newbytee commented 4 years ago

@Aokromes No, not a duplicate. Telegram Desktop does follow your GTK theme's titlebar when using X.Org/X11. The issue you linked concerns making the entire Telegram Desktop application support GTK themes, whereas this one is about disparity between rendering in Wayland and X.Org/X11.

Granted, one might argue that due to how Wayland works these issues are almost the same on a technical level, but I think the scope of reaching parity with another backend and re-implementing an entire theming system are very different.

Aokromes commented 4 years ago

implementing that will implement this.

Johnnynator commented 4 years ago

This bug is afaik fixed with qt 5.14+

Screenshot from 2020-01-27 14-27-30

github-actions[bot] commented 3 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.