search

telegramdesktop / tdesktop

Telegram Desktop messaging app
https://desktop.telegram.org/
Other
26.18k stars 5.19k forks source link

Chat user search doesn't work sometimes #7417

Open ForNeVeR opened 4 years ago

ForNeVeR commented 4 years ago

Steps to reproduce

  1. Open a supergroup chat
  2. Try to search for member (type @ and begin of member nickname)
  3. For some members in some chats, it won't work

For me, it doesn't work for a bot member (@<redacted>_bot) in supergroups with >700 and >4000 members. Other people report that they cannot find me (alongside the bot) in the same chats.

Expected behaviour

User name should still be suggested no matter the group size and other circumstances. It works in mobile clients, but doesn't work in tdesktop

Actual behaviour

Nothing is suggested.

Configuration

Operating system: Windows 10.

Version of Telegram Desktop: latest stable, 1.9.21.

Used theme: default, Night Mode is enabled.

jeffythedragonslayer commented 4 years ago

Can you see any other nicknames in the member popup above the "Write a message..." field at all?

ForNeVeR commented 4 years ago

Yes, I can see some of them, it's just this bot I can't find.

The bot is named @dotnet_<smth>_bot, and there's a member named @dotnet<smthelse>.

When I type @dot, I can see @dotnet<smthelse> user, but not @dotnet_<smth>_bot. Even if I type almost fully @dotnet_<smth>_, then I see no completion.

The same bot user could be found in some other chats, but in this particular chat it couldn't be found. Interestingly enough, I can't find this particular user, @dotnet<smthelse>, in another chat, where this user exists (and I can see them via the chat member list, but still cannot find via @-completion).

Aokromes commented 4 years ago

i don't know if this maybe server bug.

ForNeVeR commented 4 years ago

I doubt it's a server bug. Mobile clients (which, presumably, use the same API) work well for the same cases when tdesktop doesn't. It's not only me who experiences this issue, there're other people reporting the same.

Azizjan-leo commented 4 years ago

Same issue

stale[bot] commented 4 years ago

Hey there!

This issue will be automatically closed in 7 days if there would be no activity. We therefore assume that the user has lost interest or resolved the problem on their own.

Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

ForNeVeR commented 4 years ago

Still reproduces for me in random chats, only in tdesktop.

stale[bot] commented 3 years ago

Hey there!

This issue was inactive for a long time and will be automatically closed in 30 days if there isn't any further activity. We therefore assume that the user has lost interest or resolved the problem on their own.

Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

ForNeVeR commented 3 years ago

Still reproduces for me in random chats, only in tdesktop. And is pretty annoying.

stale[bot] commented 3 years ago

Hey there!

This issue was inactive for a long time and will be automatically closed in 30 days if there isn't any further activity. We therefore assume that the user has lost interest or resolved the problem on their own.

Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

ForNeVeR commented 2 years ago

Still reproduces for me in random chats, only in tdesktop. And is pretty annoying.

ILoveSkilledCoders commented 2 years ago

Hello, this is a serious problem.

I need to see all of the tags to me and my own comments and I can NEVER find them.

In one group I find 3 out of how many?

In another group, none.

Now I've lost important information because I can't find anyone who tagged me or my own comments.

This is on desktop and I tried to search in mobile b/c of what the OP said above, but it doesn't work either. It finds the last comment, that's it. How do I get to all the other comments above my last comment?

And what about all the people who wrote to me?

Please fix this.

ILoveSkilledCoders commented 2 years ago

Still reproduces for me in random chats, only in tdesktop. And is pretty annoying.

Obviously they don't plan to fix it - sigh

RememberTheAir commented 2 years ago

@ILoveSkilledCoders you can search for @ or #m, the search will return all the messages where you have been mentioned (replies + mentions by name/username). Not sure this is what you're looking for

RememberTheAir commented 2 years ago

Oh, by the way, since nobody mentioned this yet - I think that the issue of users non popping out when you type the "@" to mention someone can be somehow fixed by opening the members list and scrolling a bit, to force the app to sync the members list. This is just a workaround of course

ILoveSkilledCoders commented 2 years ago

@ILoveSkilledCoders you can search for @ or #m, the search will return all the messages where you have been mentioned (replies + mentions by name/username). Not sure this is what you're looking for

Yes, this is what I said above & no, it's not doing that for me. I've never used # though or with quotes, just @ without quotes.

Are you saying I need to use single quotes?

ILoveSkilledCoders commented 2 years ago

Oh, by the way, since nobody mentioned this yet - I think that the issue of users non popping out when you type the "@" to mention someone can be somehow fixed by opening the members list and scrolling a bit, to force the app to sync the members list. This is just a workaround of course Nope, didn't work.

In fact, now there's less entries than there were yesterday LOL Only 2 & the most recent 2, not the 3 that were there yesterday & I posted a TON yesterday, like at least 8 times.

stale[bot] commented 2 years ago

Hey there!

This issue was inactive for a long time and will be automatically closed in 30 days if there isn't any further activity. We therefore assume that the user has lost interest or resolved the problem on their own.

Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

ForNeVeR commented 2 years ago

Still reproduces, the problem is not resolved.

ILoveSkilledCoders commented 2 years ago

Yup, search still isn't working properly.

github-actions[bot] commented 1 year ago

Hey there!

This issue was inactive for a long time and will be automatically closed in 30 days if there isn't any further activity. We therefore assume that the user has lost interest or resolved the problem on their own.

Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

ForNeVeR commented 1 year ago

Just checked, it is still problematic.

github-actions[bot] commented 1 year ago

Hey there!

This issue was inactive for a long time and will be automatically closed in 30 days if there isn't any further activity. We therefore assume that the user has lost interest or resolved the problem on their own.

Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

ILoveSkilledCoders commented 1 year ago

I haven't tried in a while, but the other day I was searching for something by keywords (not a name) & I couldn't find it. This was in a group with just me & one other person.

ForNeVeR commented 1 year ago

Still reproduces for me using the same steps, no changes.

ForNeVeR commented 1 year ago

The likely reason is in this code snippet: https://github.com/telegramdesktop/tdesktop/blob/77c2e12ebc8cbbeed878056ccf660425b83e944b/Telegram/SourceFiles/chat_helpers/field_autocomplete.cpp#L472-L474

I have several hypotheses about this.

  1. The number of users in the chats I participate in may be high (up to 7000 users), and one GetFullChat request may just not return all the users. Perhaps we should send some other request to get all the users, or even send a request to get a filtered list of users, if possible?
  2. There may be some internal limit on the amount of chat member data stored, and that request may easily overflow the limit. This would also explain why random users get lost from other views, such as the excluded members list.
  3. It's also possible that the check is wrong: currently, it will only send the data request if there's no chat participant info collected. But what if we have some data collected already, from some other means (such as users entering and leaving the chat)? In such case, a full data request will almost never be sent, and tdesktop will try to reuse the existing (not nearly full) data lists to seek for the user names to complete.

Once again, I'd like to emphasize that this works flawlessly in mobile clients, so it's possible to perform this operation. It is only broken (for me at least) in tdesktop.

voed commented 11 months ago

Still reproduces even in group with ~50 members

github-actions[bot] commented 5 months ago

Hey there!

This issue was inactive for a long time and will be automatically closed in 30 days if there isn't any further activity. We therefore assume that the user has lost interest or resolved the problem on their own.

Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

ForNeVeR commented 5 months ago

You wouldn't believe, but yeah, this still reproduces for me.

nix-julia commented 4 months ago

You wouldn't believe, but yeah, this still reproduces for me.

same for me and i think it's not a server bug because on my phone there is no issue