search

telegramdesktop / tdesktop

Telegram Desktop messaging app
https://desktop.telegram.org/
Other
26.38k stars 5.24k forks source link

[Feature Request] Folders bar dark mode toggle #7460

Open brawaru opened 4 years ago

brawaru commented 4 years ago

Describe the solution you'd like

Back in the days when GitHub first introduced its header redesign, they faced some backlash by the designers and users, telling that this is not a very accessible solution. Number of extensions and user styles were made, and people like me still dislike it by this day, but that doesn't bother me as much because I mostly not at the top of the page. Telegram on the opposite has the sidebar always visible, so it bothers me and the perhaps others quite much.

A popular messaging platform among the gamers and some other communities, Discord, also had dark sidebar for a long time in light theme and it was really hated by the users as seen by enormous number of feedback site ideas and tweets. When they came up with the redesign of light theme, they faced yet another wave of complaints, this time it was for its removal — some users found it's more accessible, some just liked it dark. The solution from the Discord team was brilliant: they simply added a toggle in settings which toggles dark sidebar on and off. Everyone's happy and the life goes on. (...maybe. The redesign still wasn't well received, but that's a different story).

I propose to learn from these experiences and make the Discord-like change: for the standard light themes there should be a toggle which makes the sidebar dark, right next to accents. For the standard dark themes light sidebar will probably look bad, so toggle is unnecessary and probably should just collapse (just as accents when you switch to classic theme) or become inactive. And the custom themes just should have all these colours changeable as they see fit. (they do now!)

Screenshot from Discord settings

Discord shows a toggle in the settings to change the sidebar theme.

Did I mentioned sidebar completely ignores accent colours?

Describe alternatives you've considered

stale[bot] commented 4 years ago

Hey there!

This issue will be automatically closed in 7 days if there would be no activity. We therefore assume that the user has lost interest or resolved the problem on their own.

Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

brawaru commented 4 years ago

While you now can customize sidebar colours via custom theme, a simpler toggle for standard themes would be very much appreciated.

stale[bot] commented 3 years ago

Hey there!

This issue was inactive for a long time and will be automatically closed in 30 days if there isn't any further activity. We therefore assume that the user has lost interest or resolved the problem on their own.

Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

brawaru commented 3 years ago

Stalen't.

kass-kass commented 3 years ago

+10000000 on this, I literally don't use folders because of how horrible they look on the desktop client. If the bar wasn't dark, or was stylable in any way, or even just possible to hide, it would make things way better. I'm sure I'm not the only one missing out on a great major feature because of half-baked UI functionality.

Teklars commented 3 years ago

I just started using Folders, yeah so strange it's still not fixed, Folders sidebar on desktop client is dark and on light theme it looks annoying and more like a bug in software, in night mode it's ok, please fix it so in day mode it would be light

Aokromes commented 3 years ago

I just started using Folders, yeah so strange it's still not fixed, Folders sidebar on desktop client is dark and on light theme it looks annoying and more like a bug in software, in night mode it's ok, please fix it so in day mode it would be light

workaround: use a theme with light folder bar

Teklars commented 3 years ago

I just started using Folders, yeah so strange it's still not fixed, Folders sidebar on desktop client is dark and on light theme it looks annoying and more like a bug in software, in night mode it's ok, please fix it so in day mode it would be light

workaround: use a theme with light folder bar

so far I see themes doesn't affect folder bar, it stays dark

ctp9 commented 3 years ago

Here to confirm that this is still an issue - folders bar is stuck on Night mode and does not change when switched to Day mode.

ctp9 commented 2 years ago

Guys, it's been over a year. Change the color of the folders bar to match operating system theme / Telegram theme. Is it really that difficult? Maybe I'm just ignorant.

ilya-fedin commented 2 years ago

@ctp9 the fact a feature request exists means only that someone wants such a feature, it doesn't mean such a feature will be considered to be implemented, ever.

Aokromes commented 2 years ago

I just started using Folders, yeah so strange it's still not fixed, Folders sidebar on desktop client is dark and on light theme it looks annoying and more like a bug in software, in night mode it's ok, please fix it so in day mode it would be light

workaround: use a theme with light folder bar

so far I see themes doesn't affect folder bar, it stays dark

https://t.me/tgbetachat/934327

ctp9 commented 2 years ago

@ctp9 the fact a feature request exists means only that someone wants such a feature, it doesn't mean such a feature will be considered to be implemented, ever.

Okay, now that you say this - I think we need to escalate this "feature request" to an official "bug"... because this isn't a "feature" that we should be "requesting"...

This is something that needs to be working right out of the gate when one switches between Day/Night themes - the folders bar must switch colors accordingly. It should be considered a UI bug if the colors of the folders bar do not follow the theme setting.

ilya-fedin commented 2 years ago

This won't be accepted as a bug report anyway since this is intended

ctp9 commented 2 years ago

This won't be accepted as a bug report anyway since this is intended

So you say it is "intended". Please provide supporting evidence of the intention of the folders bar remaining dark and not adjusting with Day/system theme. That way, once we know the intention that you speak of, we can lay this idea of the folders bar adjusting colors dynamically to rest, and accept it as a self-evident feature of Telegram...

Telegram Theme Bug

ilya-fedin commented 2 years ago

Please provide supporting evidence of the intention for the folders bar remaining dark and not adjusting with Day/system theme.

I don't have such information. I only know that it's intended.

ctp9 commented 2 years ago

Yeah... not very convincing. I still think it needs to be revised and considered a UI bug. Time to evolve with the times and start making user interfaces consistent with the themes of the operating system and the application itself.

I'm sure I'm not the only one who thinks this folders bar is a major eyesore and is completely out of place looking dark on a Day theme / Light system theme.

ctp9 commented 2 years ago

It looks like sh*t. Don't continue telling Telegram's userbase that this is by design. Time to re-evaluate and adapt to modern UI expectations. We aren't stupid - our eyes are telling us that this is bad design. We need to get this considered a UI bug at this point.

ctp9 commented 2 years ago

So... what's happening here? Meanwhile every single competitor app is properly utilizing material/fluid design elements - Telegram Desktop is stuck in the dark ages. Let's please get this fixed. All it takes is a day's worth of work to get this done.

23rd commented 2 years ago

If this is such a significant problem for you, why don't you change the color of the folder bar for yourself? If it is all about colors, why it can't be done with custom themes?

ctp9 commented 2 years ago

If this is such a significant problem for you, why don't you change the color of the folder bar for yourself? If it is all about colors, why it can't be done with custom themes?

You know what - you are right. I could have just edited the theme... which I didn't think was possible on the desktop version until you mentioned it. With that said - all it took me was <1 minute of work to change the sidebar color to match the Day theme.

What's so difficult for the devs to do this too? Honestly tell please me - why is everyone here resisting making this change permanent in the Day theme? I am asking this with good intentions... not trying to stir up any conflict.

Telegram Theme Bug Manually Fixed

Aokromes commented 2 years ago

If this is such a significant problem for you, why don't you change the color of the folder bar for yourself? If it is all about colors, why it can't be done with custom themes?

You know what - you are right. I could have just edited the theme... which I didn't think was possible on the desktop version until you mentioned it. With that said - all it took me was <1 minute of work to change the sidebar color to match the Day theme.

i said that 1 year ago...

ilya-fedin commented 2 years ago

why is everyone here resisting making this change permanent in the Day theme?

Default themes look like Telegram designers see them

john-preston commented 2 years ago

@ctp9 Because the initial design mockups provided to me looked exactly the way the app looks. So "devs" didn't do this yet because there is no intention to do that - the default colors are the ones that are supposed to be.

brawaru commented 2 years ago

Kinda sorry for this guys, I didn't intend for this issue to house such entitlement, I just wanted to ask for a feature...

ctp9 commented 2 years ago

Because the initial design mockups provided to me looked exactly the way the app looks. So "devs" didn't do this yet because there is no intention to do that - the default colors are the ones that are supposed to be.

Well... thank you for responding. I still don't understand - none of these reasons and justifications make any "sense" to me. But nonetheless I appreciate you finally explaining your position. I am glad there is at least the option to manually edit themes.

Kinda sorry for this guys, I didn't intend for this issue to house such entitlement, I just wanted to ask for a feature...

Relax buddy. Just having a conversation here and trying to get some answers from the devs - there's no entitlement. The conversation is had with good intentions and in good faith... some of us are suggesting improvements for the app that can benefit everyone else who is using it.

Aokromes commented 1 year ago

I just started using Folders, yeah so strange it's still not fixed, Folders sidebar on desktop client is dark and on light theme it looks annoying and more like a bug in software, in night mode it's ok, please fix it so in day mode it would be light

workaround: use a theme with light folder bar

so far I see themes doesn't affect folder bar, it stays dark

https://t.me/addtheme/kd14jziGvcRuiuIC a theme with folder bar white.