telegramdesktop / tdesktop

Telegram Desktop messaging app
https://desktop.telegram.org/
Other
26.45k stars 5.26k forks source link

Upgrade 2.1.1 => 2.1.4: font is TOO bold #7861

Closed Flowneee closed 4 years ago

Flowneee commented 4 years ago

Hi!

I upgraded telegram-desktop (Arch Linux) from version 2.1.1 to 2.1.4 and bold font is TOO BOLD, it literally painful to read.

Old:

Screenshot_2020-05-10_16-15-20

New:

Screenshot_2020-05-10_16-18-42

From reading previous issues I assume this might be expected change, but is there any way to roll back change or provide some way to customize fonts settings?

ilya-fedin commented 4 years ago

I assume this might be expected change

This was reverted, but only for tdesktop 's own patched fonts. Distro maintainers are cutting out patched fonts.

Flowneee commented 4 years ago

This was reverted, but only for tdesktop 's own patched fonts. Distro maintainers are cutting out patched fonts.

Arch package use this to build package

cmake -B build -G Ninja . \
        -DCMAKE_INSTALL_PREFIX="/usr" \
        -DCMAKE_BUILD_TYPE=Release \
        -DTDESKTOP_API_TEST=ON \
        -DDESKTOP_APP_USE_PACKAGED_RLOTTIE=OFF \
        -DDESKTOP_APP_USE_PACKAGED_VARIANT=OFF \
        -DDESKTOP_APP_USE_PACKAGED_GSL=OFF \
        -DTDESKTOP_DISABLE_REGISTER_CUSTOM_SCHEME=ON \
        -DTDESKTOP_USE_PACKAGED_TGVOIP=OFF \
        -DDESKTOP_APP_SPECIAL_TARGET="" \
        -DTDESKTOP_LAUNCHER_BASENAME="telegramdesktop"
ninja -C build

I am not familiar with CMake, but from https://github.com/desktop-app/cmake_helpers/blob/81a0fc7970a62e8c1b194bd8eb85890528366ca7/variables.cmake I see that DESKTOP_APP_SPECIAL_TARGET="" should, in the end, set DESKTOP_APP_USE_PACKAGED_FONTS to true (ON or whatever).

Can you, please, explain, am I wrong or not? And what variable should I set (in command above) to build app with packaged fonts?

ilya-fedin commented 4 years ago

And what variable should I set (in command above) to build app with packaged fonts?

To get a proper font, you need tdesktop's own patched fonts, e.g. DESKTOP_APP_USE_PACKAGED_FONTS should be set to OFF

ilya-fedin commented 4 years ago

DESKTOP_APP_SPECIAL_TARGET="" doesn't have sense

ilya-fedin commented 4 years ago

TDESKTOP_LAUNCHER_BASENAME="telegramdesktop" too, this is default value

Flowneee commented 4 years ago

To get a proper font, you need tdesktop's own patched fonts, e.g. DESKTOP_APP_USE_PACKAGED_FONTS should be set to OFF

Okay, that was counterintuitive :)

Can this be fixed, if I somehow provide patched fonts (from https://github.com/desktop-app/lib_ui/tree/c9120970c25a279c371250fac746521e7447a69b/fonts , I suppose) manually? Just copy fonts to ~/.local/share/fonts didin't work, but probably with right fonts.conf this could work? Or I am missing something?

ilya-fedin commented 4 years ago

Okay, that was counterintuitive :)

packaged == provided by third-party == non-patched not packaged == bundled == pathced

Just copy fonts to ~/.local/share/fonts didin't work, but probably with right fonts.conf this could work?

when PACKAGED_FONTS is enabled, tdesktop request non-patched Open Sans (they have different font families)

Flowneee commented 4 years ago

Okay, thx for help. Seems like build package myself is the easiest way. I'll try to write bug report to maintainers of arch package.

ilya-fedin commented 4 years ago

I'll try to write bug report to maintainers of arch package.

there is no need, since bug actually in tdesktop codebase, fix will be in the new version

ilya-fedin commented 4 years ago

It just was unknown how the new approach affects packaged fonts

Flowneee commented 4 years ago

there is no need, since bug actually in tdesktop codebase, fix will be in the new version

Ok, thx.

github-actions[bot] commented 3 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.