Closed David-McKenna closed 8 months ago
Introduction of "MANIFEST.in" file This PR introduces a new file named "MANIFEST.in". This file is essential for better packaging of the project as it includes references to "requirements*.txt" files. These files contain necessary software dependencies our project requires to work correctly.
Update in Project's Version The version of the project specified in the "setup.py" file has been updated from 1.5.1 to 1.5.2. This means that there is a minor improvement or bugfix in the project functionality which is deemed important but not significant enough to increment the second digit.
Thanks for this too -- I should update the README
Hey Danny,
While the README does mention the intent that you should install the module from the git repo, I blindly tried to install it from pypi today and found that the install was broken, causing a FileNotFound error during the build as the setup.py file needs the requirements*.txt files to be present, but they weren't being copied to the distribution tar:
This MR simply includes those files by adding a MANIFEST.in file (tried using data_files and package_data kwargs in the setup() call to no avail), and bumps the version so that the fix is ready to be uploaded after a tag.
I tested this on a fork that I pushed to the testpypi instance, you can verify that the fix has worked on a clean python install using that distribution if you wish (https://test.pypi.org/project/debug-dpypi-pygdsm/), though you may need to pre-install setuptools via pip (failed otherwise for me as there isn't an upload of setuptools on testpypi):
pip install -i https://test.pypi.org/simple/ debug-dpypi-pygdsm
Cheers, David