search

telegraphic / pygdsm

Python interface to Global Diffuse Sky Models (GDSM) for the radio sky between 10 MHz - 5 THz
MIT License
30 stars 7 forks source link

Fixed conflicts results from merging new masking method into master #9

Closed cdilullo closed 2 years ago

cdilullo commented 2 years ago

@telegraphic, there were large conflicts on the master branch that weren't caught in the merging of fix_observer_masking into master. I've gone ahead and fixed these. Also, I reworked things to incorporate the newer obstime parameter in BaseObserver.generate().

codecov[bot] commented 2 years ago

Codecov Report

Merging #9 (57a37fb) into master (64f15e9) will increase coverage by 0.24%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   89.85%   90.09%   +0.24%     
==========================================
  Files           8        8              
  Lines         404      414      +10     
==========================================
+ Hits          363      373      +10     
  Misses         41       41
Impacted Files Coverage Δ
pygdsm/base_observer.py 97.61% <100.00%> (+0.32%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2cbad9e...57a37fb. Read the comment docs.