chan_ack should not set seq value

telehash / telehash-c

telehash tools library in c

MIT License

122 stars 31 forks source link

chan_ack should not set seq value #15

Closed alanz closed 10 years ago

alanz commented 10 years ago

https://github.com/telehash/telehash-c/blob/master/lib/chan.c#L295

The call to chan_seq_ack returns a packet with a seq value in it.

According to the spec, the bare ack should not have a seq, which will allow it to be filtered out from chan_pop delivery.

quartzjer commented 10 years ago

Yes, definitely a bug :)

quartzjer commented 10 years ago

There's been a decent amount of refactoring as I try to map a socket interface atop channels so it could still be a bit unstable, but hopefully it's a net-win here soon :)