search

telehash / telehash-c

telehash tools library in c
MIT License
122 stars 31 forks source link

Fixes to util_uri_parse for path and hash #65

Closed cfvaughnii closed 9 years ago

cfvaughnii commented 9 years ago

Variable 'encoded' wasn't being reset inside the optional path code segment at line 55 lob_set_len on line 68 should be for "hash" instead of "path"

line 57: if((at = strchr(at+1,'?')) || (at = strchr(at+1,'#'))) Segment fault in strchr(at+1,'#') if first test set 'at' to NULL

cfvaughnii commented 9 years ago

Last fix should complete segment of optional path.

cfvaughnii commented 9 years ago

Build 481 : ext_peer failed. I've seen this failure intermittently. It has nothing to do with my fix in src/util/uri.c. I believe that is correct now.

src/link.c:384 link_sync() link sync at 1438753977 ../src/ext/peer.c:109 peer_open_peer() connect delivered to zgq4vjogc5nr7sz4l5mtmzoq6l4ezba5ajkwp6chozrlfrazzkea

../src/ext/peer.c:109 peer_open_peer() connect delivered to 3sogafaacbh6bvbvzr2cr4rntbdpgksm7kpjmdvnqns2dpp7d2wq

ext_peer.c:69: test FAILED:

Failed test: link_up(linkAC)

FAILED: ext_peer make[1]: * [tests] Error 1 rm ../src/lib/jwt.o ../src/lib/socketio.o ../src/lib/base64.o ../src/ext/peer.o make[1]: Leaving directory `/home/travis/build/telehash/telehash-c/test' make: * [test] Error 2 The command "make test" exited with 2. Done. Your build exited with 1.

quartzjer commented 9 years ago

these fixes looked good, is there a reason you closed it? :)

cfvaughnii commented 9 years ago

Well, the build error was the original reason, but I decided that wasn't my issue.

Shall I re do it?

Cheers,

Frank

On Wed, Aug 5, 2015 at 3:37 PM, Jeremie Miller notifications@github.com wrote:

these fixes looked good, is there a reason you closed it? :)

— Reply to this email directly or view it on GitHub https://github.com/telehash/telehash-c/pull/65#issuecomment-128171724.

cfvaughnii commented 9 years ago

My comments on the location weren't intended as critical. I just wanted to know if there is a planned location, so I could modify the C code tests.

Cheers,

Frank

On Wednesday, August 5, 2015, Jeremie Miller notifications@github.com wrote:

these fixes looked good, is there a reason you closed it? :)

— Reply to this email directly or view it on GitHub https://github.com/telehash/telehash-c/pull/65#issuecomment-128171724.