search

telehash / telehash.github.io

Contents of the site
http://telehash.org/
Other
483 stars 59 forks source link

The hashname calculation example in node.js did not return the correct result. #126

Closed bachp closed 9 years ago

bachp commented 9 years ago

The result value is not updated and cross checked with the go implementation.

I think it would be good to add some more test vectors for hashname to the specification. Implementations could use them in their tests to verify correctness.

quartzjer commented 9 years ago

Thanks for catching that, I thought I had the right one in there. I'd love to get some formal test vectors as well, I have some in https://github.com/telehash/hashname/blob/master/test/hashname.test.js and https://github.com/telehash/telehash-c/blob/master/test/lib_hashname.c and I know @temas has some in his new lib too, perhaps it's time to split it out into a standard list?

bachp commented 9 years ago

I think a goo place would be to have a list either in the implementers guide or in a separate test vector document in the standard next to the hashname document.